You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Andrew Wong (Code Review)" <ge...@cloudera.org> on 2019/11/27 19:39:11 UTC
[kudu-CR] www: keep the /table and /tables page consistent
Hello Yifan Zhang, Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/14805
to review the following change.
Change subject: www: keep the /table and /tables page consistent
......................................................................
www: keep the /table and /tables page consistent
The /table page lists "On-Disk Size (leaders only)" for the table size,
whereas the /tables page lists "On-Disk Size (pre-replication)". This
homogenizes on the former.
Change-Id: I9b3e4052cc42ec57fa87132d12bfc97fa7777f57
---
M www/tables.mustache
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/05/14805/1
--
To view, visit http://gerrit.cloudera.org:8080/14805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9b3e4052cc42ec57fa87132d12bfc97fa7777f57
Gerrit-Change-Number: 14805
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
[kudu-CR] www: keep the /table and /tables page consistent
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14805 )
Change subject: www: keep the /table and /tables page consistent
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9b3e4052cc42ec57fa87132d12bfc97fa7777f57
Gerrit-Change-Number: 14805
Gerrit-PatchSet: 1
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>
Gerrit-Comment-Date: Wed, 27 Nov 2019 21:46:14 +0000
Gerrit-HasComments: No
[kudu-CR] www: keep the /table and /tables page consistent
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14805 )
Change subject: www: keep the /table and /tables page consistent
......................................................................
www: keep the /table and /tables page consistent
The /table page lists "On-Disk Size (leaders only)" for the table size,
whereas the /tables page lists "On-Disk Size (pre-replication)". This
homogenizes on the former.
Change-Id: I9b3e4052cc42ec57fa87132d12bfc97fa7777f57
Reviewed-on: http://gerrit.cloudera.org:8080/14805
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M www/tables.mustache
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/14805
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9b3e4052cc42ec57fa87132d12bfc97fa7777f57
Gerrit-Change-Number: 14805
Gerrit-PatchSet: 2
Gerrit-Owner: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Yifan Zhang <ch...@163.com>