You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/03/19 11:19:37 UTC
[GitHub] [incubator-shardingsphere] yu199195 opened a new pull request
#4854: to solve shadingRule, ShardingRuntimeContext init two.
yu199195 opened a new pull request #4854: to solve shadingRule, ShardingRuntimeContext init two.
URL: https://github.com/apache/incubator-shardingsphere/pull/4854
Hi,i will find shadingRule and ShardingRuntimeContext have init 2 times，
this pr can fix it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu merged pull request #4854: to
solve shadingRule, ShardingRuntimeContext init two.
Posted by GitBox <gi...@apache.org>.
terrymanu merged pull request #4854: to solve shadingRule, ShardingRuntimeContext init two.
URL: https://github.com/apache/incubator-shardingsphere/pull/4854
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] codecov-io commented on issue #4854: to
solve shadingRule, ShardingRuntimeContext init two.
Posted by GitBox <gi...@apache.org>.
codecov-io commented on issue #4854: to solve shadingRule, ShardingRuntimeContext init two.
URL: https://github.com/apache/incubator-shardingsphere/pull/4854#issuecomment-601145679
# [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=h1) Report
> Merging [#4854](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-shardingsphere/commit/d252810d280c246a9b9be22ff3f4ff1f52b7b7d7?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `75%`.
[](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4854 +/- ##
============================================
- Coverage 56.09% 56.09% -0.01%
Complexity 449 449
============================================
Files 1166 1166
Lines 20900 20899 -1
Branches 3889 3889
============================================
- Hits 11724 11723 -1
Misses 8448 8448
Partials 728 728
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...on/api/OrchestrationShardingDataSourceFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS9PcmNoZXN0cmF0aW9uU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `0% <0%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...ing/boot/OrchestrationSpringBootConfiguration.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854/diff?src=pr&el=tree#diff-c2hhcmRpbmctc3ByaW5nL3NoYXJkaW5nLWpkYmMtb3JjaGVzdHJhdGlvbi1zcHJpbmcvc2hhcmRpbmctamRiYy1vcmNoZXN0cmF0aW9uLXNwcmluZy1ib290LXN0YXJ0ZXIvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL3NwcmluZy9ib290L09yY2hlc3RyYXRpb25TcHJpbmdCb290Q29uZmlndXJhdGlvbi5qYXZh) | `88.37% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...al/datasource/OrchestrationShardingDataSource.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2ludGVybmFsL2RhdGFzb3VyY2UvT3JjaGVzdHJhdGlvblNoYXJkaW5nRGF0YVNvdXJjZS5qYXZh) | `94.87% <100%> (-0.13%)` | `0 <0> (ø)` | |
| [...ml/YamlOrchestrationShardingDataSourceFactory.java](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854/diff?src=pr&el=tree#diff-c2hhcmRpbmctamRiYy9zaGFyZGluZy1qZGJjLW9yY2hlc3RyYXRpb24vc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NoYXJkaW5namRiYy9vcmNoZXN0cmF0aW9uL2FwaS95YW1sL1lhbWxPcmNoZXN0cmF0aW9uU2hhcmRpbmdEYXRhU291cmNlRmFjdG9yeS5qYXZh) | `56.25% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=footer). Last update [d252810...2058894](https://codecov.io/gh/apache/incubator-shardingsphere/pull/4854?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #4854: to
solve shadingRule, ShardingRuntimeContext init two.
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #4854: to solve shadingRule, ShardingRuntimeContext init two.
URL: https://github.com/apache/incubator-shardingsphere/pull/4854#issuecomment-601147736
## Pull Request Test Coverage Report for [Build 10409](https://coveralls.io/builds/29469717)
* **3** of **4** **(75.0%)** changed or added relevant lines in **4** files are covered.
* **3** unchanged lines in **1** file lost coverage.
* Overall coverage decreased (**-0.007%**) to **59.634%**
---
| Changes Missing Coverage | Covered Lines | Changed/Added Lines | % |
| :-----|--------------|--------|---: |
| [sharding-jdbc/sharding-jdbc-orchestration/src/main/java/org/apache/shardingsphere/shardingjdbc/orchestration/api/OrchestrationShardingDataSourceFactory.java](https://coveralls.io/builds/29469717/source?filename=sharding-jdbc%2Fsharding-jdbc-orchestration%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Fshardingjdbc%2Forchestration%2Fapi%2FOrchestrationShardingDataSourceFactory.java#L54) | 0 | 1 | 0.0%
<!-- | **Total:** | **3** | **4** | **75.0%** | -->
| Files with Coverage Reduction | New Missed Lines | % |
| :-----|--------------|--: |
| [sharding-orchestration/sharding-orchestration-core/sharding-orchestration-core-registrycenter/src/main/java/org/apache/shardingsphere/orchestration/core/registrycenter/util/IpUtils.java](https://coveralls.io/builds/29469717/source?filename=sharding-orchestration%2Fsharding-orchestration-core%2Fsharding-orchestration-core-registrycenter%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fshardingsphere%2Forchestration%2Fcore%2Fregistrycenter%2Futil%2FIpUtils.java#L63) | 3 | 76.0% |
<!-- | **Total:** | **3** | | -->
| Totals | [](https://coveralls.io/builds/29469717) |
| :-- | --: |
| Change from base [Build 1121](https://coveralls.io/builds/29467929): | -0.007% |
| Covered Lines: | 12463 |
| Relevant Lines: | 20899 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services