[GitHub] [dubbo] zhuchao941 commented on pull request #1820: Improve graceful shutdown

[GitBox <gi...@apache.org>]

zhuchao941 commented on PR #1820:
URL: https://github.com/apache/dubbo/pull/1820#issuecomment-1275809298

   > > At present, dubbo cannot exit smoothly because spring and dubbo have hooks at the same time. The default registration will still cause unsmoothness, because spring-boot defaults to registration hooks. Spring does not register by default.
   > 
   > Hi, I have added one commit to address the issue you mentioned for SpringContainers, now it should work as expected.
   > 
   > > Because you registered the hook by default, this does not work as expected.
   > 
   > As mentioned earlier, this pull request solve this issue by ensuring only at most 1 shutdown hook is registered, to clarify:
   > 
   > scenario	shutdown hook registered
   > standalone(Bootstrap)	DubboShutdownHook
   > Spring + Dubbo	Spring shutdown hook
   > Spring boot + Dubbo	Spring shutdown hook
   > For spring-boot, I will send another pull request to incubator-dubbo-spring-boot-project
   
   have u send another pull request to dubbo-spring-boot-project?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org