You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/12/02 02:29:00 UTC
[GitHub] [incubator-eventmesh] Alonexc opened a new issue, #2385: [Enhancement] Method stores return result in local before immediately returning it [HttpSummaryMetrics]
Alonexc opened a new issue, #2385:
URL: https://github.com/apache/incubator-eventmesh/issues/2385
### Search before asking
- [X] I had searched in the [issues](https://github.com/apache/eventmesh/issues?q=is%3Aissue) and found no similar issues.
### Enhancement Request
located at:
eventmesh-metrics-plugin/eventmesh-metrics-api/src/main/java/org/apache/eventmesh/metrics/api/model/HttpSummaryMetrics.java line 64 69 95 100 130 164 169 229 234 326 331 390 400 410
analysis and explanation:
This method stores the return result in a local variable, and then immediately returns the local variable. It would be simpler just to return the value that is assigned to the local variable,
### Describe the solution you'd like
reference:
### Are you willing to submit PR?
- [ ] Yes I am willing to submit a PR!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] keranbingaa commented on issue #2385: [Enhancement] Method stores return result in local before immediately returning it [HttpSummaryMetrics]
Posted by GitBox <gi...@apache.org>.
keranbingaa commented on issue #2385:
URL: https://github.com/apache/incubator-eventmesh/issues/2385#issuecomment-1334828276
I want to fix it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] jonyangx closed issue #2385: [Enhancement] Method stores return result in local before immediately returning it [HttpSummaryMetrics]
Posted by GitBox <gi...@apache.org>.
jonyangx closed issue #2385: [Enhancement] Method stores return result in local before immediately returning it [HttpSummaryMetrics]
URL: https://github.com/apache/incubator-eventmesh/issues/2385
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org