You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/06/22 08:19:45 UTC

[GitHub] [apisix-dashboard] bzp2010 commented on pull request #1947: fix: logger on Windows

bzp2010 commented on pull request #1947:
URL: https://github.com/apache/apisix-dashboard/pull/1947#issuecomment-865686306


   @nic-chen 
   > Please test manually to confirm that there is no problem, since CI does not support Windows currently.
   
   I found that when I remove the code in `conf.go` to get the absolute path of the file, I can directly use the relative path to write the log on windows.
   
   But in order to be compatible with the file path printed in `printInfo`, I added some compromise code, such as `ErrorLogPathAbs`. At the same time, I will refactor the configuration module in another PR (#1946) to solve these problems.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org