[GitHub] [kafka] ijuma commented on a change in pull request #10918: KAFKA-12756: Update ZooKeeper to v3.6.3

[GitBox <gi...@apache.org>]

ijuma commented on a change in pull request #10918:
URL: https://github.com/apache/kafka/pull/10918#discussion_r656620095



##########
File path: docs/upgrade.html
##########
@@ -21,6 +21,13 @@
 
 <h5><a id="upgrade_300_notable" href="#upgrade_300_notable">Notable changes in 3.0.0</a></h5>
 <ul>
+    <li>ZooKeeper has been upgraded to 3.6.3, and that version has a hard dependency on the
+        <code>io.dropwizard.metrics:metrics-core:3.2.5</code> library due to the new metrics subsystem added in 3.6.0.
+        Setting <code>metricsProvider.className=org.apache.zookeeper.metrics.impl.NullMetricsProvider</code> in your
+        zookeeper.properties file does not remove this dependency.  ZooKeeper will fail to start with
+        <code>java.lang.NoClassDefFoundError: com/codahale/metrics/Reservoir</code> if you do not have the above library
+        on your CLASSPATH.
+    </li>

Review comment:
       Isn't this handled automatically for users?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org