You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "martinzink (via GitHub)" <gi...@apache.org> on 2026/10/05 14:09:35 UTC
[PR] MINIFICPP-2915 Add rust extensions into msi installer [nifi-minifi-cpp]
martinzink opened a new pull request, #2275:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2275
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2915 Add rust extensions into msi installer [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on code in PR #2275:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2275#discussion_r4185629431
##########
CMakeLists.txt:
##########
@@ -772,6 +774,8 @@ set(EXTENSIONS_ENABLED_BY_DEFAULT (
minifi-sql
minifi-standard-processors
minifi-wel
+ minifi_pgp
+ minifi_tensor
Review Comment:
let's keep the tensor extension disabled by default. I'm not sure its interface is stable yet.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2915 Add rust extensions into msi installer [nifi-minifi-cpp]
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #2275:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2275#discussion_r4184960510
##########
minifi_rust/CMakeLists.txt:
##########
@@ -39,11 +39,15 @@ if (NOT ENABLE_TEST_PROCESSORS)
set_target_properties(cargo-build_minifi_rs_playground PROPERTIES EXCLUDE_FROM_ALL TRUE)
endif()
-if (NOT MINIFI_EXTENSION_PGP)
+if (MINIFI_EXTENSION_PGP)
+ register_rust_extension(minifi_pgp "PGP EXTENSION" MINIFI_EXTENSION_PGP "This enables EncryptContentPGP and DecryptContentPGP")
+else()
set_target_properties(cargo-build_minifi_pgp PROPERTIES EXCLUDE_FROM_ALL TRUE)
endif()
-if (NOT MINIFI_EXTENSION_TENSOR)
+if (MINIFI_EXTENSION_TENSOR)
+ register_rust_extension(minifi_tensor "TENSOR EXTENSION" MINIFI_EXTENSION_TENSOR "This enables tract based tensor processors")
Review Comment:
"tract" is too common a word:
```suggestion
register_rust_extension(minifi_tensor "TENSOR EXTENSION" MINIFI_EXTENSION_TENSOR "This enables sonos/tract based tensor processors")
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] MINIFICPP-2915 Add rust extensions into msi installer [nifi-minifi-cpp]
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm merged PR #2275:
URL: https://github.com/apache/nifi-minifi-cpp/pull/2275
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org