You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2010/03/31 14:34:57 UTC

DO NOT REPLY [Bug 49030] New: Processing of Tomcat Connector configuration can leave some connectors uninitialized

https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

           Summary: Processing of Tomcat Connector configuration can leave
                    some connectors uninitialized
           Product: Tomcat 6
           Version: 6.0.26
          Platform: PC
        OS/Version: Windows Server 2003
            Status: NEW
          Severity: normal
          Priority: P2
         Component: Catalina
        AssignedTo: dev@tomcat.apache.org
        ReportedBy: al.java@bcpraha.com


If the Server part of the Tomcat 6 configuration is beeing processed and there
are more connectory defined, it seems to be the fact the exceptions during the
connector initialization are not catched properly, so if there comes some
exception by the initialization of one connector (for example to try to
initialize the new connector for the same port like had the already initialized
connector), then no other connectors are processed and created (no one
listening port is allocated) even if such other connectors are defined
properly. It leads to the situation the connectory are then initialized
differently if the order of the connectors changes. It can be very confusing if
searching some error in the definitions. Together with the fact, the default
server.xml contains at least in some cases the invalid connector definition it
leads to serious confusion it searching the configuration problem...

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

--- Comment #5 from Konstantin Kolinko <kn...@gmail.com> 2010-06-23 21:47:06 EDT ---
Created an attachment (id=25633)
 --> (https://issues.apache.org/bugzilla/attachment.cgi?id=25633)
2010-06-24_tc6_bug49030.patch

Patch for tc6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

--- Comment #3 from Artur Linhart <al...@bcpraha.com> 2010-03-31 13:11:05 UTC ---
Great, thank You.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |hauser@acm.org

--- Comment #8 from Mark Thomas <ma...@apache.org> 2011-04-12 18:12:06 EDT ---
*** Bug 46461 has been marked as a duplicate of this bug. ***

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

Mark Thomas <ma...@apache.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #7 from Mark Thomas <ma...@apache.org> 2010-09-22 10:56:47 EDT ---
This has been fixed in 6.0.x and will be included in 6.0.30 onwards.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

--- Comment #2 from Mark Thomas <ma...@apache.org> 2010-03-31 13:07:37 UTC ---
This has been fixed in trunk and proposed for 6.0.x

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

--- Comment #1 from Artur Linhart <al...@bcpraha.com> 2010-03-31 12:40:56 UTC ---
It is then the problem especially in the connection with the bug 49031

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

--- Comment #4 from Konstantin Kolinko <kn...@gmail.com> 2010-06-23 09:08:38 EDT ---
I like this, but there are caveats implementing this feature:

1. Connectors that fail in a call to initialize() will also likely to fail in
start(), pause(), stop(). Thus all the loops over connectors have to be
safeguarded.

This includes loops over array returned by StandardService.findConnectors(),
e.g. in ServerLifecycleListener#destroyMBeans(Service).


2. Need to reimplement support for 

org.apache.catalina.startup.EXIT_ON_INIT_FAILURE=true

configuration property [1], [2].

[1] http://tomcat.apache.org/tomcat-6.0-doc/config/systemprops.html
[2] https://issues.apache.org/bugzilla/show_bug.cgi?id=48625

As a test case for this feature one can try to start a second instance of
Tomcat using the same configuration.

If the above EXIT_ON_INIT_FAILURE setting is added to conf/catalina.properties,
Tomcat 6.0.27 will abort startup on the first init() failure.

If the init() exception were caught and startup continued, as proposed patch
does, the abort does not happen.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org

DO NOT REPLY [Bug 49030] Processing of Tomcat Connector configuration can leave some connectors uninitialized

Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=49030

--- Comment #6 from Konstantin Kolinko <kn...@gmail.com> 2010-06-25 11:24:23 EDT ---
I ported the patch to TC7 and applied in r957960,

but my testing shows that the fix for bug 48625 included there does not work,
because Connector.init() does not behave as expected. I created bug 49503 to
track that.

-- 
Configure bugmail: https://issues.apache.org/bugzilla/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org