You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/09/03 05:52:47 UTC

[GitHub] [airflow] xinbinhuang edited a comment on pull request #17987: AwsBaseHook make client_type optional in get_client_type

xinbinhuang edited a comment on pull request #17987:
URL: https://github.com/apache/airflow/pull/17987#issuecomment-912276682


   `.get_resource_type` has the same problem. Would be nice to change it here as well.
   
   It will be even better! if we can refactor them somehow, it seems really confusing to me to have `client|resource_type` in both the constructor and the methods.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org