You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@predictionio.apache.org by takezoe <gi...@git.apache.org> on 2017/07/13 06:23:45 UTC

[GitHub] incubator-predictionio pull request #407: [PIO-104] Make proper implementati...

GitHub user takezoe opened a pull request:

    https://github.com/apache/incubator-predictionio/pull/407

    [PIO-104] Make proper implementation of plugins

    - Remove start() method of EventServerPlugin and EngineServerPlugin
    - Send prediction result to outputSniffers in the engine server
    
    http://mail-archives.apache.org/mod_mbox/incubator-predictionio-dev/201706.mbox/%3CCAF_HxLtEonOVALSQgrCRGXctAbL7eypxwG0ErHpaBJJym15j5Q%40mail.gmail.com%3E

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/takezoe/incubator-predictionio fix-plugin-impl

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-predictionio/pull/407.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #407
    
----
commit 66218c8167c200109aea423af2f1ac543082d633
Author: Naoki Takezoe <ta...@apache.org>
Date:   2017-07-13T06:12:29Z

    [PIO-104] Make proper implementation of plugins
    
    - Remove start() method of EventServerPlugin and EngineServerPlugin
    - Send prediction result to outputSniffers in the engine server

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio issue #407: [PIO-104] Make proper implementation of p...

Posted by dszeto <gi...@git.apache.org>.
Github user dszeto commented on the issue:

    https://github.com/apache/incubator-predictionio/pull/407
  
    LGTM. Thanks @takezoe !


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] incubator-predictionio pull request #407: [PIO-104] Make proper implementati...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-predictionio/pull/407


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---