[GitHub] [mynewt-nimble] sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.

[GitBox <gi...@apache.org>]

sjanc commented on a change in pull request #740: nimble/ll: Add possible to set BT v5.2 flag plus some minor changes.
URL: https://github.com/apache/mynewt-nimble/pull/740#discussion_r371223736
 
 

 ##########
 File path: nimble/controller/src/ble_ll.c
 ##########
 @@ -1277,6 +1280,46 @@ ble_ll_read_supp_features(void)
     return g_ble_ll_data.ll_supp_features;
 }
 
+/**
+ * Sets the features controlled by the host.
+ *
+ * @return HCI command status
+ */
+int
+ble_ll_set_host_feat(const uint8_t *cmdbuf, uint8_t len)
+{
+#if MYNEWT_VAL(BLE_VERSION) >= 52
 
 Review comment:
   this is not needed since caller is already doing #ifdef foo

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services