You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@flume.apache.org by Juhani Connolly <ju...@cyberagent.co.jp> on 2013/01/25 03:02:23 UTC
Reminder to close tickets on review board
Hi guys,
could you just check your open tickets on review board("all my
requests") and close up any that have been committed or discarded?
Looked like there was a lot of backlog but it turns out many of the
tickets have already been committed, hard to distinguish them from ones
that need review. A couple of them also don't have "ship it" but have
been committed.
Thanks,
Juhani
Re: Reminder to close tickets on review board
Posted by Roshan Naik <ro...@hortonworks.com>.
Juhani / Hari ... could you guys take a stab at reviewing this... its
relatively small patch.
FLUME-1661
https://reviews.apache.org/r/7748/
-roshan
On Fri, Jan 25, 2013 at 2:18 PM, Hari Shreedharan <hshreedharan@cloudera.com
> wrote:
> If a committer +1-ed it, then you can ping the dev@ list to make sure it
> is committed (if the committer does not do it immediately). Else, you can
> ask the committers to review it by pinging the dev@ list or updating the
> jira.
>
> Hari
>
> --
> Hari Shreedharan
>
>
> On Friday, January 25, 2013 at 2:05 PM, Roshan Naik wrote:
>
> > what about the ones that say 'ship it' but not committed ? (FLUME-1661)
> >
> >
> > On Fri, Jan 25, 2013 at 7:13 AM, Brock Noland <brock@cloudera.com(mailto:
> brock@cloudera.com)> wrote:
> >
> > > +1
> > >
> > > I'll check mine today.
> > >
> > > On Thu, Jan 24, 2013 at 9:20 PM, Jarek Jarcec Cecho <jarcec@apache.org(mailto:
> jarcec@apache.org)>
> > > wrote:
> > > > Thanks for reminding Juhani, I've closed all my opened reviews.
> > > >
> > > > Jarcec
> > > >
> > > > On Fri, Jan 25, 2013 at 11:02:23AM +0900, Juhani Connolly wrote:
> > > > > Hi guys,
> > > > > could you just check your open tickets on review board("all my
> > > > > requests") and close up any that have been committed or discarded?
> > > > > Looked like there was a lot of backlog but it turns out many of the
> > > > > tickets have already been committed, hard to distinguish them from
> > > > > ones that need review. A couple of them also don't have "ship it"
> > > > > but have been committed.
> > > > >
> > > > > Thanks,
> > > > > Juhani
> > > > >
> > > >
> > > >
> > >
> > >
> > >
> > >
> > > --
> > > Apache MRUnit - Unit testing MapReduce -
> > > http://incubator.apache.org/mrunit/
> > >
> >
> >
> >
>
>
>
Re: Reminder to close tickets on review board
Posted by Hari Shreedharan <hs...@cloudera.com>.
If a committer +1-ed it, then you can ping the dev@ list to make sure it is committed (if the committer does not do it immediately). Else, you can ask the committers to review it by pinging the dev@ list or updating the jira.
Hari
--
Hari Shreedharan
On Friday, January 25, 2013 at 2:05 PM, Roshan Naik wrote:
> what about the ones that say 'ship it' but not committed ? (FLUME-1661)
>
>
> On Fri, Jan 25, 2013 at 7:13 AM, Brock Noland <brock@cloudera.com (mailto:brock@cloudera.com)> wrote:
>
> > +1
> >
> > I'll check mine today.
> >
> > On Thu, Jan 24, 2013 at 9:20 PM, Jarek Jarcec Cecho <jarcec@apache.org (mailto:jarcec@apache.org)>
> > wrote:
> > > Thanks for reminding Juhani, I've closed all my opened reviews.
> > >
> > > Jarcec
> > >
> > > On Fri, Jan 25, 2013 at 11:02:23AM +0900, Juhani Connolly wrote:
> > > > Hi guys,
> > > > could you just check your open tickets on review board("all my
> > > > requests") and close up any that have been committed or discarded?
> > > > Looked like there was a lot of backlog but it turns out many of the
> > > > tickets have already been committed, hard to distinguish them from
> > > > ones that need review. A couple of them also don't have "ship it"
> > > > but have been committed.
> > > >
> > > > Thanks,
> > > > Juhani
> > > >
> > >
> > >
> >
> >
> >
> >
> > --
> > Apache MRUnit - Unit testing MapReduce -
> > http://incubator.apache.org/mrunit/
> >
>
>
>
Re: Reminder to close tickets on review board
Posted by Roshan Naik <ro...@hortonworks.com>.
what about the ones that say 'ship it' but not committed ? (FLUME-1661)
On Fri, Jan 25, 2013 at 7:13 AM, Brock Noland <br...@cloudera.com> wrote:
> +1
>
> I'll check mine today.
>
> On Thu, Jan 24, 2013 at 9:20 PM, Jarek Jarcec Cecho <ja...@apache.org>
> wrote:
> > Thanks for reminding Juhani, I've closed all my opened reviews.
> >
> > Jarcec
> >
> > On Fri, Jan 25, 2013 at 11:02:23AM +0900, Juhani Connolly wrote:
> >> Hi guys,
> >> could you just check your open tickets on review board("all my
> >> requests") and close up any that have been committed or discarded?
> >> Looked like there was a lot of backlog but it turns out many of the
> >> tickets have already been committed, hard to distinguish them from
> >> ones that need review. A couple of them also don't have "ship it"
> >> but have been committed.
> >>
> >> Thanks,
> >> Juhani
>
>
>
> --
> Apache MRUnit - Unit testing MapReduce -
> http://incubator.apache.org/mrunit/
>
Re: Reminder to close tickets on review board
Posted by Brock Noland <br...@cloudera.com>.
+1
I'll check mine today.
On Thu, Jan 24, 2013 at 9:20 PM, Jarek Jarcec Cecho <ja...@apache.org> wrote:
> Thanks for reminding Juhani, I've closed all my opened reviews.
>
> Jarcec
>
> On Fri, Jan 25, 2013 at 11:02:23AM +0900, Juhani Connolly wrote:
>> Hi guys,
>> could you just check your open tickets on review board("all my
>> requests") and close up any that have been committed or discarded?
>> Looked like there was a lot of backlog but it turns out many of the
>> tickets have already been committed, hard to distinguish them from
>> ones that need review. A couple of them also don't have "ship it"
>> but have been committed.
>>
>> Thanks,
>> Juhani
--
Apache MRUnit - Unit testing MapReduce - http://incubator.apache.org/mrunit/
Re: Reminder to close tickets on review board
Posted by Jarek Jarcec Cecho <ja...@apache.org>.
Thanks for reminding Juhani, I've closed all my opened reviews.
Jarcec
On Fri, Jan 25, 2013 at 11:02:23AM +0900, Juhani Connolly wrote:
> Hi guys,
> could you just check your open tickets on review board("all my
> requests") and close up any that have been committed or discarded?
> Looked like there was a lot of backlog but it turns out many of the
> tickets have already been committed, hard to distinguish them from
> ones that need review. A couple of them also don't have "ship it"
> but have been committed.
>
> Thanks,
> Juhani