You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by "harikrishna-patnala (via GitHub)" <gi...@apache.org> on 2025/09/03 01:54:57 UTC
Re: [PR] removed code in comments [cloudstack]
harikrishna-patnala commented on code in PR #11145:
URL: https://github.com/apache/cloudstack/pull/11145#discussion_r2317567484
##########
framework/ipc/src/test/java/org/apache/cloudstack/framework/codestyle/AsyncSampleEventDrivenStyleCaller.java:
##########
@@ -53,12 +56,8 @@ public void MethodThatWillCallAsyncMethod() {
try {
String result = future.get();
Assert.assertEquals(result, vol);
- } catch (InterruptedException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
- } catch (ExecutionException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
+ } catch (InterruptedException | ExecutionException e) {
+ logger.error(e);
Review Comment:
is warn better here, since we are continuing ?
##########
framework/ipc/src/test/java/org/apache/cloudstack/framework/codestyle/AsyncSampleEventDrivenStyleCaller.java:
##########
@@ -87,10 +86,8 @@ public String getResult() {
if (!this.finished) {
try {
this.wait();
-
} catch (InterruptedException e) {
- // TODO Auto-generated catch block
- e.printStackTrace();
+ logger.error(e);
Review Comment:
is warn better here, since we are continuing ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org