[GitHub] [rocketmq] RongtongJin commented on a diff in pull request #6417: [ISSUE #6205] Support Async pull for DefaultLitePullConsumer

["RongtongJin (via GitHub)" <gi...@apache.org>]

RongtongJin commented on code in PR #6417:
URL: https://github.com/apache/rocketmq/pull/6417#discussion_r1142800711


##########
client/src/main/java/org/apache/rocketmq/client/impl/consumer/DefaultLitePullConsumerImpl.java:
##########
@@ -860,9 +861,16 @@ public class PullTaskImpl implements Runnable {
         private final MessageQueue messageQueue;
         private volatile boolean cancelled = false;
         private Thread currentThread;
+        private final CommunicationMode communicationMode;
 
         public PullTaskImpl(final MessageQueue messageQueue) {
             this.messageQueue = messageQueue;
+            communicationMode = CommunicationMode.SYNC;
+        }
+
+        public PullTaskImpl(final MessageQueue messageQueue, CommunicationMode communicationMode) {
+            this.messageQueue = messageQueue;
+            this.communicationMode = communicationMode;

Review Comment:
   Good job! How do users set whether the pullTask is asynchronous or synchronous?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org