You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "pandaapo (via GitHub)" <gi...@apache.org> on 2023/05/22 13:07:52 UTC
[GitHub] [eventmesh] pandaapo opened a new pull request, #4006: [ISSUE #4005]Resolve all checkstyle related errors in CI and unify header to 'checkstyle-header.txt'
pandaapo opened a new pull request, #4006:
URL: https://github.com/apache/eventmesh/pull/4006
Fixes #4005.
### Motivation
See "Enhancement Request" in [issue](https://github.com/apache/eventmesh/issues/4005#issue-1719624951).
### Modifications
Unify files header with format errors as 'checkstyle-header.txt'.
### Documentation
- Does this pull request introduce a new feature? (yes / no)
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
- If a feature is not applicable for documentation, explain why?
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] pandaapo commented on pull request #4006: [ISSUE #4005]Resolve all checkstyle related errors in CI and unify header to 'checkstyle-header.txt'
Posted by "pandaapo (via GitHub)" <gi...@apache.org>.
pandaapo commented on PR #4006:
URL: https://github.com/apache/eventmesh/pull/4006#issuecomment-1557201787
@xwm1992 This pr has nothing but fixes checkstyle error, about wrong format of file header comparing with 'checkstyle-header.txt', reported by CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] codecov[bot] commented on pull request #4006: [ISSUE #4005]Resolve all checkstyle related errors in CI and unify header to 'checkstyle-header.txt'
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #4006:
URL: https://github.com/apache/eventmesh/pull/4006#issuecomment-1560363131
## [Codecov](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
> Merging [#4006](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (4138ea6) into [master](https://app.codecov.io/gh/apache/eventmesh/commit/7c0ed46bc169f0e0a277e312c837826ab07d0cc6?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) (7c0ed46) will **increase** coverage by `0.20%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4138ea6 differs from pull request most recent head a8f3957. Consider uploading reports for the commit a8f3957 to get more accurate results
```diff
@@ Coverage Diff @@
## master #4006 +/- ##
============================================
+ Coverage 14.03% 14.23% +0.20%
- Complexity 1293 1320 +27
============================================
Files 572 579 +7
Lines 28839 28951 +112
Branches 2808 2801 -7
============================================
+ Hits 4047 4121 +74
- Misses 24416 24439 +23
- Partials 376 391 +15
```
| [Impacted Files](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [.../eventmesh/common/loadbalance/LoadBalanceType.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLWNvbW1vbi9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZXZlbnRtZXNoL2NvbW1vbi9sb2FkYmFsYW5jZS9Mb2FkQmFsYW5jZVR5cGUuamF2YQ==) | `80.00% <ø> (ø)` | |
| [...h/runtime/admin/controller/HttpHandlerManager.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL2NvbnRyb2xsZXIvSHR0cEhhbmRsZXJNYW5hZ2VyLmphdmE=) | `100.00% <ø> (ø)` | |
| [...mesh/runtime/admin/request/CreateTopicRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvQ3JlYXRlVG9waWNSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [...runtime/admin/request/DeleteGrpcClientRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlR3JwY0NsaWVudFJlcXVlc3QuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...runtime/admin/request/DeleteHTTPClientRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlSFRUUENsaWVudFJlcXVlc3QuamF2YQ==) | `0.00% <ø> (ø)` | |
| [.../runtime/admin/request/DeleteTCPClientRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlVENQQ2xpZW50UmVxdWVzdC5qYXZh) | `0.00% <ø> (ø)` | |
| [...mesh/runtime/admin/request/DeleteTopicRequest.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3JlcXVlc3QvRGVsZXRlVG9waWNSZXF1ZXN0LmphdmE=) | `0.00% <ø> (ø)` | |
| [...ntime/admin/response/GetConfigurationResponse.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3Jlc3BvbnNlL0dldENvbmZpZ3VyYXRpb25SZXNwb25zZS5qYXZh) | `0.00% <ø> (ø)` | |
| [...entmesh/runtime/admin/utils/HttpExchangeUtils.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2FkbWluL3V0aWxzL0h0dHBFeGNoYW5nZVV0aWxzLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ache/eventmesh/runtime/boot/SSLContextFactory.java](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ZXZlbnRtZXNoLXJ1bnRpbWUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2V2ZW50bWVzaC9ydW50aW1lL2Jvb3QvU1NMQ29udGV4dEZhY3RvcnkuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [53 more](https://app.codecov.io/gh/apache/eventmesh/pull/4006?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | |
... and [19 files with indirect coverage changes](https://app.codecov.io/gh/apache/eventmesh/pull/4006/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] xwm1992 merged pull request #4006: [ISSUE #4005]Resolve all checkstyle related errors in CI and unify header to 'checkstyle-header.txt'
Posted by "xwm1992 (via GitHub)" <gi...@apache.org>.
xwm1992 merged PR #4006:
URL: https://github.com/apache/eventmesh/pull/4006
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org