[GitHub] [hive] kgyrtkirk commented on a change in pull request #876: HIVE-22585: Clean up catalog/db/table name usage

[GitBox <gi...@apache.org>]

kgyrtkirk commented on a change in pull request #876: HIVE-22585: Clean up catalog/db/table name usage
URL: https://github.com/apache/hive/pull/876#discussion_r381992821
 
 

 ##########
 File path: ql/src/java/org/apache/hadoop/hive/ql/cache/results/QueryResultsCache.java
 ##########
 @@ -631,13 +632,13 @@ public long getSize() {
     }
   }
 
-  public void notifyTableChanged(String dbName, String tableName, long updateTime) {
-    LOG.debug("Table changed: {}.{}, at {}", dbName, tableName, updateTime);
+  public void notifyTableChanged(TableName tableName, long updateTime) {
+    LOG.debug("Table changed: {}, at {}", tableName.getNotEmptyDbTable(), updateTime);
     // Invalidate all cache entries using this table.
     List<CacheEntry> entriesToInvalidate = null;
     rwLock.writeLock().lock();
     try {
-      String key = (dbName.toLowerCase() + "." + tableName.toLowerCase());
+      String key = (tableName.getNotEmptyDbTable().toLowerCase());
 
 Review comment:
   we might want to consider to remove all these "toLowerCase"  calls;and instead make it a contract for tablenames; so it's enforced at the time the tablename is created

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org