You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2016/02/29 01:07:21 UTC
Review Request 44149: Renamed a method in docker runtime isolator.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44149/
-----------------------------------------------------------
Review request for mesos, Gilbert Song and Timothy Chen.
Repository: mesos
Description
-------
The original name is not accurate. We're trying to get the docker
container launch command, not the executor launch command.
Diffs
-----
src/slave/containerizer/mesos/isolators/docker/runtime.hpp 507505aa247d4c587ce10ca60536df4b7f0d1674
src/slave/containerizer/mesos/isolators/docker/runtime.cpp 4241f4c127e89ac02d1b7838041836edbeb75672
Diff: https://reviews.apache.org/r/44149/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 44149: Renamed a method in docker runtime isolator.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44149/#review121175
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Feb. 28, 2016, 4:07 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44149/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2016, 4:07 p.m.)
>
>
> Review request for mesos, Gilbert Song and Timothy Chen.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The original name is not accurate. We're trying to get the docker
> container launch command, not the executor launch command.
>
>
> Diffs
> -----
>
> src/slave/containerizer/mesos/isolators/docker/runtime.hpp 507505aa247d4c587ce10ca60536df4b7f0d1674
> src/slave/containerizer/mesos/isolators/docker/runtime.cpp 4241f4c127e89ac02d1b7838041836edbeb75672
>
> Diff: https://reviews.apache.org/r/44149/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>