You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@orc.apache.org by GitBox <gi...@apache.org> on 2020/11/05 14:56:46 UTC

[GitHub] [orc] pgaref opened a new pull request #563: ORC-684: [C++] Make Floating point NaN check more strict

pgaref opened a new pull request #563:
URL: https://github.com/apache/orc/pull/563


   Change-Id: I33b987fff6eaaba80a3d31ff34237334c28063aa
   
   ### What changes were proposed in this pull request?
   ORC-636 added an extra check (part of  RecordReaderImp) disabling PPD when DoubleColumnStats min, max or sum is a non-Finite number.
   
   However, the check is unnecessarily broad – the way stats are updated, using just sum for the check would suffice.
   
   
   ### Why are the changes needed?
   Make NAN check for DoubleStats (used for PPD) more strict
   
   
   ### How was this patch tested?
   TestPredicateLeaf.cc
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [orc] pgaref closed pull request #563: ORC-684: [C++] Make Floating point NaN check more strict

Posted by GitBox <gi...@apache.org>.

pgaref closed pull request #563:
URL: https://github.com/apache/orc/pull/563


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org