You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geronimo.apache.org by Kevan Miller <ke...@gmail.com> on 2010/08/29 00:46:02 UTC
Re: svn commit: r990077 - /geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
On Aug 27, 2010, at 5:33 AM, xuhaihong@apache.org wrote:
> Author: xuhaihong
> Date: Fri Aug 27 09:33:58 2010
> New Revision: 990077
>
> URL: http://svn.apache.org/viewvc?rev=990077&view=rev
> Log:
> GERONIMO-5558 Transaction Commit status is not configured correctly
>
> Modified:
> geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
>
> Modified: geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
> URL: http://svn.apache.org/viewvc/geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java?rev=990077&r1=990076&r2=990077&view=diff
This needs to be merged into active branches/trunk, I think. Ivan, you planning on doing that?
--kevan
Re: svn commit: r990077 - /geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
Posted by Ivan <xh...@gmail.com>.
I also merge the changes to trunk at revision: 990716, any comment will be
appreciated,
2010/8/30 Ivan <xh...@gmail.com>
> Yes, it is a obvious change, there are still some other tx changes
> required, I will merge them together to trunk soon.
>
>
> 2010/8/30 Kevan Miller <ke...@gmail.com>
>
>
>> On Aug 28, 2010, at 10:21 PM, Ivan wrote:
>>
>> > Yes, after verfying the changes in TCK, I will merge it to trunk.
>>
>> Hi Ivan,
>> I think you could proactively merge... That seemed like a pretty obvious
>> change. Great catch, by the way! Was good timing finding the bug, as I ran
>> into what looks like the same problem in another environment...
>>
>> --kevan
>
>
>
>
> --
> Ivan
>
--
Ivan
Re: svn commit: r990077 - /geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
Posted by Ivan <xh...@gmail.com>.
Yes, it is a obvious change, there are still some other tx changes required,
I will merge them together to trunk soon.
2010/8/30 Kevan Miller <ke...@gmail.com>
>
> On Aug 28, 2010, at 10:21 PM, Ivan wrote:
>
> > Yes, after verfying the changes in TCK, I will merge it to trunk.
>
> Hi Ivan,
> I think you could proactively merge... That seemed like a pretty obvious
> change. Great catch, by the way! Was good timing finding the bug, as I ran
> into what looks like the same problem in another environment...
>
> --kevan
--
Ivan
Re: svn commit: r990077 - /geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
Posted by Kevan Miller <ke...@gmail.com>.
On Aug 28, 2010, at 10:21 PM, Ivan wrote:
> Yes, after verfying the changes in TCK, I will merge it to trunk.
Hi Ivan,
I think you could proactively merge... That seemed like a pretty obvious change. Great catch, by the way! Was good timing finding the bug, as I ran into what looks like the same problem in another environment...
--kevan
Re: svn commit: r990077 - /geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
Posted by Ivan <xh...@gmail.com>.
Yes, after verfying the changes in TCK, I will merge it to trunk.
2010/8/29 Kevan Miller <ke...@gmail.com>
>
> On Aug 27, 2010, at 5:33 AM, xuhaihong@apache.org wrote:
>
> > Author: xuhaihong
> > Date: Fri Aug 27 09:33:58 2010
> > New Revision: 990077
> >
> > URL: http://svn.apache.org/viewvc?rev=990077&view=rev
> > Log:
> > GERONIMO-5558 Transaction Commit status is not configured correctly
> >
> > Modified:
> >
> geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
> >
> > Modified:
> geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java
> > URL:
> http://svn.apache.org/viewvc/geronimo/components/txmanager/branches/geronimo-txmanager-parent-2.1/geronimo-transaction/src/main/java/org/apache/geronimo/transaction/manager/CommitTask.java?rev=990077&r1=990076&r2=990077&view=diff
>
> This needs to be merged into active branches/trunk, I think. Ivan, you
> planning on doing that?
>
> --kevan
--
Ivan