You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2021/10/25 10:03:24 UTC
[GitHub] [ozone] JacksonYao287 opened a new pull request #2765: HDDS-5889. add suggested LeaderID in NotLeaderException in OM
JacksonYao287 opened a new pull request #2765:
URL: https://github.com/apache/ozone/pull/2765
## What changes were proposed in this pull request?
for now , ozone client will not fail over if a notLeader exception is thrown.
this patch adds suggested LeaderID in NotLeaderException , so that ozone client can fail over according to the suggested leader
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-5889
Please replace this section with the link to the Apache JIRA)
## How was this patch tested?
current UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org
[GitHub] [ozone] hanishakoneru commented on pull request #2765: HDDS-5889. add suggested LeaderID in NotLeaderException in OM
Posted by GitBox <gi...@apache.org>.
hanishakoneru commented on pull request #2765:
URL: https://github.com/apache/ozone/pull/2765#issuecomment-952091699
@JacksonYao287, previously the client would failover to the suggested leader. It was changed in HDDS-3334 as it caused issues if the client configs are not in line with the server configs. For example, let's say the server nodeId to OM address mapping is as follows:
```
om1 -> node1
om2 -> node2
om3 -> node3
```
But the client configuration has this mapping as follows:
```
om1 -> node2
om2 -> node3
om1 -> node1
```
Let's say the leader is node1. Client contacts node2 and gets back suggested leader as om1 (as per the server). So it fails over to om1 (which according to its configuration is node2). So it contacts node2 again and this loop is repeated and client never fails over to the correct leader.
Though generally we don't expect client and server mappings to be different, it is possible to have. So, it would be good to failover based on node address than to rely just on the nodeId.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org