[GitHub] [lucene-solr] diegoceccarelli opened a new pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping

[GitBox <gi...@apache.org>]

diegoceccarelli opened a new pull request #819: SOLR-13676: Reduce log verbosity in TestDistributedGrouping 
URL: https://github.com/apache/lucene-solr/pull/819
 
 
   using ignoreException
   
   # Description
   
   SOLR-13404 added a test that expects Solr to fail if grouping is called with group.offset < 0. When the test runs it succeeds but the whole stack trace is printed out in the logs. 
   # Solution
   
   This small patch avoid the stack trace by using ignoreException. I also replaced an `assertTrue` with a more specific check. 
   
   # Tests
   
   This patch is improving a test.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [x] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [x] I have created a Jira issue and added the issue ID to my pull request title.
   - [x] I am authorized to contribute this code to the ASF and have removed any code I do not have a license to distribute.
   - [x] I have developed this patch against the `master` branch.
   - [-] I have run `ant precommit` and the appropriate test suite.
   - [x] I have added tests for my changes.
   - [...] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org