[GitHub] tysonnorris commented on a change in pull request #2939: invoker cmd line support for dyanamicId assignment

[GitBox <gi...@apache.org>]

tysonnorris commented on a change in pull request #2939: invoker cmd line support for dyanamicId assignment
URL: https://github.com/apache/incubator-openwhisk/pull/2939#discussion_r149815355
 
 

 ##########
 File path: core/invoker/src/main/scala/whisk/core/invoker/Invoker.scala
 ##########
 @@ -104,8 +107,24 @@ object Invoker {
       abort("Bad configuration, cannot start.")
     }
 
-    val proposedInvokerId: Option[Int] = args.headOption.map(_.toInt)
-    val assignedInvokerId = proposedInvokerId
+    // process command line arguments
+    // We accept the command line grammar of:
+    // Usage: invoker [options] [<proposedInvokerId>]
+    //    --name <value>   a unique name to use for this invoker
 
 Review comment:
   are there any restrictions on what characters can be passed here for --name? (I assume not, like dots and dashes should work?)

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services