[GitHub] [druid] gianm commented on a change in pull request #10697: Supporting filters in the left base table for join datasources

[GitBox <gi...@apache.org>]

gianm commented on a change in pull request #10697:
URL: https://github.com/apache/druid/pull/10697#discussion_r587918370



##########
File path: processing/src/main/java/org/apache/druid/segment/join/HashJoinSegmentStorageAdapter.java
##########
@@ -69,8 +70,25 @@
       final List<JoinableClause> clauses,
       final JoinFilterPreAnalysis joinFilterPreAnalysis
   )
+  {
+    this(baseAdapter, null, clauses, joinFilterPreAnalysis);
+  }
+
+  /**
+   * @param baseAdapter           A StorageAdapter for the left-hand side base segment
+   * @param baseFilter            A filter for the left-hand side base segment
+   * @param clauses               The right-hand side clauses. The caller is responsible for ensuring that there are no

Review comment:
       No what?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org