You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Sailaja Polavarapu <sp...@hortonworks.com> on 2020/10/14 01:20:28 UTC
Review Request 72959: RANGER-3038: Group memberships not getting
updated to ranger
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72959/
-----------------------------------------------------------
Review request for ranger, Abhay Kulkarni, Mahesh Bandal, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
Bugs: RANGER-3038
https://issues.apache.org/jira/browse/RANGER-3038
Repository: ranger
Description
-------
Fixed issue with group memberships update to ranger admin.
Diffs
-----
security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 74431b0e0
security-admin/src/main/resources/META-INF/jpa_named_queries.xml a8f581849
Diff: https://reviews.apache.org/r/72959/diff/1/
Testing
-------
Patched cluster with changes and verified the functionality.
Thanks,
Sailaja Polavarapu
Re: Review Request 72959: RANGER-3038: Group memberships not getting
updated to ranger
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
> On Oct. 14, 2020, 1:34 a.m., Madhan Neethiraj wrote:
> > security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java
> > Lines 109 (patched)
> > <https://reviews.apache.org/r/72959/diff/1/?file=2240724#file2240724line109>
> >
> > Consider moving #109 to inside following for-loop:
> >
> > for (String userName : users) {
> > ...
> >
> > XXGroupUser xxGroupUser = groupUsers.get(username);
> > boolean groupUserMappingExists = xxGroupUser != null;
> >
> > ...
> >
> > if (groupUserMappingExists) {
> > xxGroupUser = getDao().update(xxGroupUser);
> > } else {
> > xxGroupUser = new XXGroupUser();
> >
> > ...
> >
> > xxGroupUser = getDao().create(xxGroupUser);
> > }
> > }
Moved #109 inside for-loop as suggested. But still we need to create xxGroupUser when it is null before #122. Hope this is ok.
- Sailaja
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72959/#review222042
-----------------------------------------------------------
On Oct. 14, 2020, 1:20 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72959/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2020, 1:20 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Mahesh Bandal, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3038
> https://issues.apache.org/jira/browse/RANGER-3038
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed issue with group memberships update to ranger admin.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 74431b0e0
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml a8f581849
>
>
> Diff: https://reviews.apache.org/r/72959/diff/1/
>
>
> Testing
> -------
>
> Patched cluster with changes and verified the functionality.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 72959: RANGER-3038: Group memberships not getting
updated to ranger
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72959/#review222042
-----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java
Lines 109 (patched)
<https://reviews.apache.org/r/72959/#comment311111>
Consider moving #109 to inside following for-loop:
for (String userName : users) {
...
XXGroupUser xxGroupUser = groupUsers.get(username);
boolean groupUserMappingExists = xxGroupUser != null;
...
if (groupUserMappingExists) {
xxGroupUser = getDao().update(xxGroupUser);
} else {
xxGroupUser = new XXGroupUser();
...
xxGroupUser = getDao().create(xxGroupUser);
}
}
- Madhan Neethiraj
On Oct. 14, 2020, 1:20 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72959/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2020, 1:20 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Mahesh Bandal, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3038
> https://issues.apache.org/jira/browse/RANGER-3038
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed issue with group memberships update to ranger admin.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 74431b0e0
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml a8f581849
>
>
> Diff: https://reviews.apache.org/r/72959/diff/1/
>
>
> Testing
> -------
>
> Patched cluster with changes and verified the functionality.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 72959: RANGER-3038: Group memberships not getting
updated to ranger
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72959/#review222046
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Oct. 14, 2020, 5:33 a.m., Sailaja Polavarapu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/72959/
> -----------------------------------------------------------
>
> (Updated Oct. 14, 2020, 5:33 a.m.)
>
>
> Review request for ranger, Abhay Kulkarni, Mahesh Bandal, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3038
> https://issues.apache.org/jira/browse/RANGER-3038
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Fixed issue with group memberships update to ranger admin.
>
>
> Diffs
> -----
>
> security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 74431b0e0
> security-admin/src/main/resources/META-INF/jpa_named_queries.xml a8f581849
>
>
> Diff: https://reviews.apache.org/r/72959/diff/2/
>
>
> Testing
> -------
>
> Patched cluster with changes and verified the functionality.
>
>
> Thanks,
>
> Sailaja Polavarapu
>
>
Re: Review Request 72959: RANGER-3038: Group memberships not getting
updated to ranger
Posted by Sailaja Polavarapu <sp...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72959/
-----------------------------------------------------------
(Updated Oct. 14, 2020, 5:33 a.m.)
Review request for ranger, Abhay Kulkarni, Mahesh Bandal, Mehul Parikh, Ramesh Mani, and Velmurugan Periasamy.
Changes
-------
Incorporated review comments.
Bugs: RANGER-3038
https://issues.apache.org/jira/browse/RANGER-3038
Repository: ranger
Description
-------
Fixed issue with group memberships update to ranger admin.
Diffs (updated)
-----
security-admin/src/main/java/org/apache/ranger/service/XGroupUserService.java 74431b0e0
security-admin/src/main/resources/META-INF/jpa_named_queries.xml a8f581849
Diff: https://reviews.apache.org/r/72959/diff/2/
Changes: https://reviews.apache.org/r/72959/diff/1-2/
Testing
-------
Patched cluster with changes and verified the functionality.
Thanks,
Sailaja Polavarapu