You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cordova.apache.org by GitBox <gi...@apache.org> on 2020/01/19 06:19:37 UTC
[GitHub] [cordova-plugin-file] zorn-v opened a new pull request #371: [WIP]
Native electron support
zorn-v opened a new pull request #371: [WIP] Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371
<!--
Please make sure the checklist boxes are all checked before submitting the PR. The checklist is intended as a quick reference, for complete details please see our Contributor Guidelines:
http://cordova.apache.org/contribute/contribute_guidelines.html
Thanks!
-->
### Platforms affected
Electron
### Motivation and Context
Use native nodejs functions for filesystem instead of writing files to chrome IndexedDB of electron app.
### Testing
Clone https://github.com/zorn-v/cordova-electron-file-test and run `npm run electron` in it
### Checklist
- [ ] resolveLocalFileSystemURL should resolve correct paths
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file] cyberplant commented on issue #371: Native
electron support
Posted by GitBox <gi...@apache.org>.
cyberplant commented on issue #371: Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371#issuecomment-607551470
Thanks @zorn-v , I'll check that, as I'm in the same situation as @miroslavvojtus and probably others..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file] zorn-v commented on issue #371: Native
electron support
Posted by GitBox <gi...@apache.org>.
zorn-v commented on issue #371: Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371#issuecomment-578037432
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file] miroslavvojtus commented on issue #371:
Native electron support
Posted by GitBox <gi...@apache.org>.
miroslavvojtus commented on issue #371: Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371#issuecomment-604326223
Hi All is there any possibility this will ho in near future into release? It would be realy helpfull for us. As of now we are implementing it manually in application code what is sort of anti-pattern in regards to cordova architecture to make native calls in plugin layer.
@zorn-v Good job with this attempt. We would be happy to use your contribution.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file] zorn-v commented on issue #371: Native
electron support
Posted by GitBox <gi...@apache.org>.
zorn-v commented on issue #371: Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371#issuecomment-604335742
@miroslavvojtus
You can use `cordova plugin add https://github.com/zorn-v/cordova-plugin-file.git#electron`
Or change it in `package.json` etc. to `git+https://github.com/zorn-v/cordova-plugin-file.git#electron`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file] zorn-v edited a comment on issue #371: Native
electron support
Posted by GitBox <gi...@apache.org>.
zorn-v edited a comment on issue #371: Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371#issuecomment-604335742
@miroslavvojtus
You can use `cordova plugin add https://github.com/zorn-v/cordova-plugin-file.git#electron`
Or change it in `package.json` etc. to `git+https://github.com/zorn-v/cordova-plugin-file.git#electron` and run something like `rm -rf plugins/cordova-plugin-file && npx cordova prepare`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org
[GitHub] [cordova-plugin-file] zorn-v commented on issue #371: [WIP] Native
electron support
Posted by GitBox <gi...@apache.org>.
zorn-v commented on issue #371: [WIP] Native electron support
URL: https://github.com/apache/cordova-plugin-file/pull/371#issuecomment-575974434
Currently I don't know how to execute native nodejs `require` for `require('electron')` because cordova override it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cordova.apache.org
For additional commands, e-mail: commits-help@cordova.apache.org