You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "huangxiaopingRD (via GitHub)" <gi...@apache.org> on 2023/03/01 12:26:03 UTC
[GitHub] [spark] huangxiaopingRD opened a new pull request, #40232: [SPARK-42629][DOCS] Update the description of default data source in the document
huangxiaopingRD opened a new pull request, #40232:
URL: https://github.com/apache/spark/pull/40232
### What changes were proposed in this pull request?
Update the description of default data source in the document.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jaceklaskowski commented on a diff in pull request #40232: [SPARK-42629][DOCS] Update the description of default data source in the document
Posted by "jaceklaskowski (via GitHub)" <gi...@apache.org>.
jaceklaskowski commented on code in PR #40232:
URL: https://github.com/apache/spark/pull/40232#discussion_r1151011001
##########
docs/sql-ref-syntax-ddl-create-table-datasource.md:
##########
@@ -118,7 +118,7 @@ CREATE TABLE student (id INT, name STRING, age INT) USING CSV;
CREATE TABLE student_copy USING CSV
AS SELECT * FROM student;
---Omit the USING clause, which uses the default data source (parquet by default)
+--Omit the USING clause, which uses the default data source (textfile by default)
Review Comment:
Why is this change? I thought `parquet` is the default data source (by `spark.sql.sources.default`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huangxiaopingRD commented on a diff in pull request #40232: [SPARK-42629][DOCS] Update the description of default data source in the document
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #40232:
URL: https://github.com/apache/spark/pull/40232#discussion_r1153014538
##########
docs/sql-ref-syntax-ddl-create-table-datasource.md:
##########
@@ -118,7 +118,7 @@ CREATE TABLE student (id INT, name STRING, age INT) USING CSV;
CREATE TABLE student_copy USING CSV
AS SELECT * FROM student;
---Omit the USING clause, which uses the default data source (parquet by default)
+--Omit the USING clause, which uses the default data source (textfile by default)
Review Comment:
The hive table format depends on the conf hive.default.fileformat when set spark.sql.legacy.createHiveTableByDefault is true . And if spark.sql.legacy.createHiveTableByDefault is false, it hive table format depends on the conf spark.sql.sources.default . Now spark.sql.legacy.createHiveTableByDefault is true, and the table created by default is textfile.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42629][DOCS] Update the description of default data source in the document [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #40232: [SPARK-42629][DOCS] Update the description of default data source in the document
URL: https://github.com/apache/spark/pull/40232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-42629][DOCS] Update the description of default data source in the document [spark]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #40232:
URL: https://github.com/apache/spark/pull/40232#issuecomment-1747828492
We're closing this PR because it hasn't been updated in a while. This isn't a judgement on the merit of the PR in any way. It's just a way of keeping the PR queue manageable.
If you'd like to revive this PR, please reopen it and ask a committer to remove the Stale tag!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] huangxiaopingRD commented on a diff in pull request #40232: [SPARK-42629][DOCS] Update the description of default data source in the document
Posted by "huangxiaopingRD (via GitHub)" <gi...@apache.org>.
huangxiaopingRD commented on code in PR #40232:
URL: https://github.com/apache/spark/pull/40232#discussion_r1153014538
##########
docs/sql-ref-syntax-ddl-create-table-datasource.md:
##########
@@ -118,7 +118,7 @@ CREATE TABLE student (id INT, name STRING, age INT) USING CSV;
CREATE TABLE student_copy USING CSV
AS SELECT * FROM student;
---Omit the USING clause, which uses the default data source (parquet by default)
+--Omit the USING clause, which uses the default data source (textfile by default)
Review Comment:
The hive table format depends on the conf `hive.default.fileformat` when set `spark.sql.legacy.createHiveTableByDefault` is true . And if `spark.sql.legacy.createHiveTableByDefault` is false, it hive table format depends on the conf `spark.sql.sources.default` . Now `spark.sql.legacy.createHiveTableByDefault` is true, and the table created by default is `textfile`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org