[GitHub] [iceberg] rdblue commented on a change in pull request #3745: Push down partition filter to Spark when Importing File Based Tables

[GitBox <gi...@apache.org>]

rdblue commented on a change in pull request #3745:
URL: https://github.com/apache/iceberg/pull/3745#discussion_r780824012



##########
File path: spark/v3.2/spark/src/main/java/org/apache/iceberg/spark/Spark3Util.java
##########
@@ -745,9 +750,11 @@ public static TableIdentifier identifierToTableIdentifier(Identifier identifier)
    * @param spark a Spark session
    * @param rootPath a table identifier
    * @param format format of the file
+   * @param partitionFilter partitionFilter of the file
    * @return all table's partitions
    */
-  public static List<SparkPartition> getPartitions(SparkSession spark, Path rootPath, String format) {
+  public static List<SparkPartition> getPartitions(SparkSession spark, String tableName, Path rootPath, String format,

Review comment:
       Because this was a public method, I think we need to maintain the API and add the previous version back with a default `partitionFilter`.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org