[GitHub] [arrow] pitrou commented on a change in pull request #12479: ARROW-15739: [C++] Bump xsimd to latest version

[GitBox <gi...@apache.org>]

pitrou commented on a change in pull request #12479:
URL: https://github.com/apache/arrow/pull/12479#discussion_r812018750



##########
File path: cpp/src/arrow/csv/writer.cc
##########
@@ -216,13 +216,9 @@ class UnquotedColumnPopulator : public ColumnPopulator {
     const int64_t buffer_size = array.total_values_length();
     int64_t offset = 0;
 #if defined(ARROW_HAVE_SSE4_2) || defined(ARROW_HAVE_NEON)
-#if defined(ARROW_HAVE_SSE4_2)
     // _mm_cmpistrc gives slightly better performance than the naive approach,
     // probably doesn't deserve the effort
-    using simd_batch = xsimd::batch<uint8_t, xsimd::sse4_2>;
-#else
-    using simd_batch = xsimd::batch<uint8_t, xsimd::neon64>;
-#endif
+    using simd_batch = xsimd::make_sized_batch_t<uint8_t, 16>;

Review comment:
       This is going to be more convenient to use :-)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org