You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2020/03/25 13:27:07 UTC

[GitHub] [beam] alexvanboxel opened a new pull request #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder

alexvanboxel opened a new pull request #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder
URL: https://github.com/apache/beam/pull/11218
 
 
   Rename setRowOption to setOption on Option builder as setRowOption
   name is too confusing.
   
   It sets an option as a Row, not an option on a Row. Using setOption
   is better and doesn't conflict with the other setOption with 3
   parameters and explicit type.
   
   This commit also removed left over @Nullable annotations.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] alexvanboxel commented on issue #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder

Posted by GitBox <gi...@apache.org>.

alexvanboxel commented on issue #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder
URL: https://github.com/apache/beam/pull/11218#issuecomment-604281831
 
 
   Run Java PreCommit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

[GitHub] [beam] alexvanboxel merged pull request #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder

Posted by GitBox <gi...@apache.org>.

alexvanboxel merged pull request #11218: [BEAM-9605] BIP-1: Rename setRowOption to setOption on Option builder
URL: https://github.com/apache/beam/pull/11218
 
 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services