You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Chip Childers <ch...@sungard.com> on 2013/04/03 15:27:01 UTC
Re: Review Request: Fix for CLOUDSTACK-1839. To be applied to 4.1.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10250/
-----------------------------------------------------------
(Updated April 3, 2013, 1:27 p.m.)
Review request for cloudstack and Chip Childers.
Changes
-------
adding cloudstack group for ML visibility
Description
-------
The bug was because when Rohit rolled back the schema file he rolled it back to 4.0 schema file - the index file. We no longer add to the index file so that mistake is understandable but there were left over indexes and constraints in that file. What I did is moved it directly on to create-schema.sql.
Chip, Please add this to 4.1 and I will cherry-pick over to master.
Diffs
-----
setup/db/create-schema.sql 7361681
Diff: https://reviews.apache.org/r/10250/diff/
Testing
-------
I tested manually by checking on the indexes after the db creation is done but before management server starts up. Unfortunately, there's no actual diff that tell me the difference QA was looking for so I couldn't match it exactly to what QA thinks should be in the newly created schema. QA will need to verify everything they want is there in the new schema now.
Thanks,
Alex Huang
Re: Review Request: Fix for CLOUDSTACK-1839. To be applied to 4.1.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10250/#review18649
-----------------------------------------------------------
Commit d24a45abaa5ed3073855892e581a46ba87c92fa5 in branch refs/heads/master from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=d24a45a ]
Added fixes for CLOUDSTACK-1839. Missing lots of indexes due to a rollback to 4.0 by Rohit
- ASF Subversion and Git Services
On April 3, 2013, 1:41 p.m., Alex Huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10250/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 1:41 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> The bug was because when Rohit rolled back the schema file he rolled it back to 4.0 schema file - the index file. We no longer add to the index file so that mistake is understandable but there were left over indexes and constraints in that file. What I did is moved it directly on to create-schema.sql.
>
> Chip, Please add this to 4.1 and I will cherry-pick over to master.
>
>
> This addresses bug CLOUDSTACK-1839.
>
>
> Diffs
> -----
>
> setup/db/create-schema.sql 7361681
>
> Diff: https://reviews.apache.org/r/10250/diff/
>
>
> Testing
> -------
>
> I tested manually by checking on the indexes after the db creation is done but before management server starts up. Unfortunately, there's no actual diff that tell me the difference QA was looking for so I couldn't match it exactly to what QA thinks should be in the newly created schema. QA will need to verify everything they want is there in the new schema now.
>
>
> Thanks,
>
> Alex Huang
>
>
Re: Review Request: Fix for CLOUDSTACK-1839. To be applied to 4.1.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10250/#review18648
-----------------------------------------------------------
Ship it!
applied to 4.1 and cherry-picked to master
- Chip Childers
On April 3, 2013, 1:41 p.m., Alex Huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10250/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 1:41 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> The bug was because when Rohit rolled back the schema file he rolled it back to 4.0 schema file - the index file. We no longer add to the index file so that mistake is understandable but there were left over indexes and constraints in that file. What I did is moved it directly on to create-schema.sql.
>
> Chip, Please add this to 4.1 and I will cherry-pick over to master.
>
>
> This addresses bug CLOUDSTACK-1839.
>
>
> Diffs
> -----
>
> setup/db/create-schema.sql 7361681
>
> Diff: https://reviews.apache.org/r/10250/diff/
>
>
> Testing
> -------
>
> I tested manually by checking on the indexes after the db creation is done but before management server starts up. Unfortunately, there's no actual diff that tell me the difference QA was looking for so I couldn't match it exactly to what QA thinks should be in the newly created schema. QA will need to verify everything they want is there in the new schema now.
>
>
> Thanks,
>
> Alex Huang
>
>
Re: Review Request: Fix for CLOUDSTACK-1839. To be applied to 4.1.
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10250/#review18647
-----------------------------------------------------------
Commit fe1113f2f1a8c3586a08fa0f17c71f2574ffed7b in branch refs/heads/4.1 from Chip Childers <ch...@gmail.com>
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=fe1113f ]
Added fixes for CLOUDSTACK-1839. Missing lots of indexes due to a rollback to 4.0 by Rohit
- ASF Subversion and Git Services
On April 3, 2013, 1:41 p.m., Alex Huang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/10250/
> -----------------------------------------------------------
>
> (Updated April 3, 2013, 1:41 p.m.)
>
>
> Review request for cloudstack and Chip Childers.
>
>
> Description
> -------
>
> The bug was because when Rohit rolled back the schema file he rolled it back to 4.0 schema file - the index file. We no longer add to the index file so that mistake is understandable but there were left over indexes and constraints in that file. What I did is moved it directly on to create-schema.sql.
>
> Chip, Please add this to 4.1 and I will cherry-pick over to master.
>
>
> This addresses bug CLOUDSTACK-1839.
>
>
> Diffs
> -----
>
> setup/db/create-schema.sql 7361681
>
> Diff: https://reviews.apache.org/r/10250/diff/
>
>
> Testing
> -------
>
> I tested manually by checking on the indexes after the db creation is done but before management server starts up. Unfortunately, there's no actual diff that tell me the difference QA was looking for so I couldn't match it exactly to what QA thinks should be in the newly created schema. QA will need to verify everything they want is there in the new schema now.
>
>
> Thanks,
>
> Alex Huang
>
>
Re: Review Request: Fix for CLOUDSTACK-1839. To be applied to 4.1.
Posted by Chip Childers <ch...@sungard.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/10250/
-----------------------------------------------------------
(Updated April 3, 2013, 1:41 p.m.)
Review request for cloudstack and Chip Childers.
Description
-------
The bug was because when Rohit rolled back the schema file he rolled it back to 4.0 schema file - the index file. We no longer add to the index file so that mistake is understandable but there were left over indexes and constraints in that file. What I did is moved it directly on to create-schema.sql.
Chip, Please add this to 4.1 and I will cherry-pick over to master.
This addresses bug CLOUDSTACK-1839.
Diffs
-----
setup/db/create-schema.sql 7361681
Diff: https://reviews.apache.org/r/10250/diff/
Testing
-------
I tested manually by checking on the indexes after the db creation is done but before management server starts up. Unfortunately, there's no actual diff that tell me the difference QA was looking for so I couldn't match it exactly to what QA thinks should be in the newly created schema. QA will need to verify everything they want is there in the new schema now.
Thanks,
Alex Huang