You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "wankai123 (via GitHub)" <gi...@apache.org> on 2024/09/13 04:16:28 UTC

[PR] Fix `findEndpoint` query require `keyword` when using BanyanDB. [skywalking]

wankai123 opened a new pull request, #12615:
URL: https://github.com/apache/skywalking/pull/12615

   And 
   - Rollback `SeriesID` in `ZipkinServiceSpanTraffic` relate to https://github.com/apache/skywalking/pull/12474
   - bump up banyandb version for e2e
   
   - [ ] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #<issue number>.
   - [X] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/docs/en/changes/changes.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix `findEndpoint` query require `keyword` when using BanyanDB. [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng merged PR #12615:
URL: https://github.com/apache/skywalking/pull/12615


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] Fix `findEndpoint` query require `keyword` when using BanyanDB. [skywalking]

Posted by "wu-sheng (via GitHub)" <gi...@apache.org>.
wu-sheng commented on code in PR #12615:
URL: https://github.com/apache/skywalking/pull/12615#discussion_r1758212168


##########
docs/en/changes/changes.md:
##########
@@ -63,6 +63,7 @@
 * Support service level metrics aggregate when missing pod context in eBPF Access Log Receiver.
 * Fix query `getGlobalTopology` throw exception when didn't find any services by the given Layer.
 * Fix the previous analysis result missing in the ALS `k8s-mesh` analyzer.
+* Fix `findEndpoint` query require `keyword` when using BanyanDB.

Review Comment:
   > * BanyanDB: Zipkin Module set service as Entity for improving the query performance.
   
   Previous change log should be reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org