[GitHub] [iceberg] aokolnychyi commented on a change in pull request #2858: Core: Support multiple specs in OutputFileFactory

[GitBox <gi...@apache.org>]

aokolnychyi commented on a change in pull request #2858:
URL: https://github.com/apache/iceberg/pull/2858#discussion_r676043003



##########
File path: core/src/main/java/org/apache/iceberg/io/OutputFileFactory.java
##########
@@ -95,25 +100,71 @@ public OutputFileFactory(PartitionSpec spec, FileFormat format, LocationProvider
     this.operationId = operationId;
   }
 
+  public static Builder builderFor(Table table, FileFormat format, int partitionId, long taskId) {

Review comment:
       It is a bit debatable what we consider as required arguments. I think these 4 are always set.
   
   We may consider defaulting the format to the current table format for data files but we have to ensure it is the same format we use in data writers. That's why it safer to always require an explicit value.
   
   We can default partition and task IDs to 1 just for tests. These values must be always set in real scenarios.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org