You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2024/02/21 05:54:15 UTC

[kudu-CR] [rpc] fix typo in branch prediction

Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/21044


Change subject: [rpc] fix typo in branch prediction
......................................................................

[rpc] fix typo in branch prediction

This is a follow-up to 3f0c434143ad6daa8ed4f39d8ceacbe58604dd29

Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
---
M src/kudu/rpc/service_pool.cc
1 file changed, 1 insertion(+), 1 deletion(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/21044/1
-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rpc] fix typo in branch prediction
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Abhishek Chennaka (Code Review)" <ge...@cloudera.org>.
Abhishek Chennaka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 )

Change subject: [rpc] fix typo in branch prediction
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 00:28:50 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21044 )

Change subject: [rpc] fix typo in branch prediction
......................................................................

[rpc] fix typo in branch prediction

This is a follow-up to 3f0c434143ad6daa8ed4f39d8ceacbe58604dd29

Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Reviewed-on: http://gerrit.cloudera.org:8080/21044
Reviewed-by: Abhishek Chennaka <ac...@cloudera.com>
Tested-by: Alexey Serbin <al...@apache.org>
---
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_queue-test.cc
2 files changed, 2 insertions(+), 2 deletions(-)

Approvals:
  Abhishek Chennaka: Looks good to me, approved
  Alexey Serbin: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Zoltan Martonka (Code Review)" <ge...@cloudera.org>.
Zoltan Martonka has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 )

Change subject: [rpc] fix typo in branch prediction
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 07:36:47 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed a vote on this change.

Change subject: [rpc] fix typo in branch prediction
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 )

Change subject: [rpc] fix typo in branch prediction
......................................................................


Patch Set 1: Verified+1

Unrelated test failures:
CatalogManagerConfigurations/MasterStressTest.Test/3
TableKeyRangeTest.TestGetTableKeyRange
TsTabletManagerITest.TestTableStats
ClientTest.TestDeleteWithDeletedTableReserveSecondsWorks


-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Wed, 21 Feb 2024 18:34:41 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21044 )

Change subject: [rpc] fix typo in branch prediction
......................................................................


Patch Set 2: Verified+1

unrelated test failures in
    ClientTest.ClearCacheAndConcurrentWorkload
    SslWebserverTest.TestSSL
    SecurityITest.TestNonDefaultPrincipalMultipleMaster


-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>
Gerrit-Comment-Date: Thu, 22 Feb 2024 00:44:49 +0000
Gerrit-HasComments: No

[kudu-CR] [rpc] fix typo in branch prediction

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Zoltan Martonka, Kudu Jenkins, Abhishek Chennaka, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21044

to look at the new patch set (#2).

Change subject: [rpc] fix typo in branch prediction
......................................................................

[rpc] fix typo in branch prediction

This is a follow-up to 3f0c434143ad6daa8ed4f39d8ceacbe58604dd29

Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
---
M src/kudu/rpc/service_pool.cc
M src/kudu/rpc/service_queue-test.cc
2 files changed, 2 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/44/21044/2
-- 
To view, visit http://gerrit.cloudera.org:8080/21044
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I5af612277dc5b03bdee597212885d47c823a6025
Gerrit-Change-Number: 21044
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Abhishek Chennaka <ac...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Zoltan Martonka <zm...@cloudera.com>