You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by "Lunderberg (via GitHub)" <gi...@apache.org> on 2023/06/05 17:35:28 UTC
[GitHub] [tvm] Lunderberg opened a new pull request, #15025: [Unity][NN] Allow nn.Placeholder/Parameter prior to BlockBuilder
Lunderberg opened a new pull request, #15025:
URL: https://github.com/apache/tvm/pull/15025
Prior to this commit, use of `nn.Placeholder` or `nn.Parameter` outside of a `with block_builder.function('name'):` scope resulted in an error. This commit updates the behavior to allow declaration prior to entering the `with` block. This can be useful for declaring a model object, which is then used to define several related functions.
The scope was required so that `relax.BlockBuilder.current()` could de-duplicate variable names. While two distinct variables in Relax may have identical names, for user readability it is convenient to have all names be unique within a Relax function. This commit maintains the de-duplication of names if a `nn.Placeholder` or `nn.Parameter` is defined within an active `relax.BlockBuilder`, that context may be used to provide a unique name.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] tvm-bot commented on pull request #15025: [Unity][NN] Allow nn.Placeholder/Parameter prior to BlockBuilder
Posted by "tvm-bot (via GitHub)" <gi...@apache.org>.
tvm-bot commented on PR #15025:
URL: https://github.com/apache/tvm/pull/15025#issuecomment-1577202913
<!---bot-comment-->
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from [Reviewers](https://github.com/apache/incubator-tvm/blob/master/CONTRIBUTORS.md#reviewers) by @-ing them in a comment.
<!--bot-comment-ccs-start-->
* cc @quic-sanirudh <sub>See [#10317](https://github.com/apache/tvm/issues/10317) for details</sub><!--bot-comment-ccs-end-->
<sub>Generated by [tvm-bot](https://github.com/apache/tvm/blob/main/ci/README.md#github-actions)</sub>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] quic-sanirudh merged pull request #15025: [Unity][NN] Allow nn.Placeholder/Parameter prior to BlockBuilder
Posted by "quic-sanirudh (via GitHub)" <gi...@apache.org>.
quic-sanirudh merged PR #15025:
URL: https://github.com/apache/tvm/pull/15025
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org