You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by we...@apache.org on 2019/05/03 19:15:22 UTC
[arrow] branch master updated: ARROW-5253: [C++] Fix snappy
external build
This is an automated email from the ASF dual-hosted git repository.
wesm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 6c626c8 ARROW-5253: [C++] Fix snappy external build
6c626c8 is described below
commit 6c626c82953a45901cd0ac1d580b3f26807591df
Author: François Saint-Jacques <fs...@gmail.com>
AuthorDate: Fri May 3 14:15:04 2019 -0500
ARROW-5253: [C++] Fix snappy external build
CMAKE_INSTALL_LIBDIR is not propagated thus fails on systems that uses
`lib64` (alpine and possibly redhat derivatives).
Author: François Saint-Jacques <fs...@gmail.com>
Closes #4246 from fsaintjacques/ARROW-5253-snappy-external and squashes the following commits:
f6b0bc7f8 <François Saint-Jacques> ARROW-5253: Fix snappy external build
---
cpp/cmake_modules/ThirdpartyToolchain.cmake | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 80c9746..35a1d4e 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -601,7 +601,10 @@ macro(build_snappy)
"${SNAPPY_PREFIX}/lib/${CMAKE_STATIC_LIBRARY_PREFIX}${SNAPPY_STATIC_LIB_NAME}${CMAKE_STATIC_LIBRARY_SUFFIX}"
)
- set(SNAPPY_CMAKE_ARGS ${EP_COMMON_CMAKE_ARGS} -DSNAPPY_BUILD_TESTS=OFF
+ set(SNAPPY_CMAKE_ARGS
+ ${EP_COMMON_CMAKE_ARGS}
+ -DCMAKE_INSTALL_LIBDIR=lib
+ -DSNAPPY_BUILD_TESTS=OFF
"-DCMAKE_INSTALL_PREFIX=${SNAPPY_PREFIX}")
externalproject_add(snappy_ep