You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Sanjay Tripathi <sa...@citrix.com> on 2012/07/31 11:10:49 UTC
Review Request: CS-15698: No option to update customer vpn gateway details
through UI
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6230/
-----------------------------------------------------------
Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
Description
-------
No option to update customer vpn gateway details through UI
Steps to Reproduce:
==============
1.Bring UP CS in advanced zone
2.In UI go to Network->Select VPN Customer Gateway->add VPN Customer Gateway
3.Click on the vpn gateway added at step 2
Details page has tabs to create vpn connection and to delete vpn customer gateway
Does not have option to update vpn customer gateway.
This addresses bug CS-15698.
Diffs
-----
ui/scripts/network.js 0ae3850
Diff: https://reviews.apache.org/r/6230/diff/
Testing
-------
Verified on my local cloudstack setup.
Currently only "IPsec Presharedkey" is kept as editable field, incase if there is any need to make other fields as editable, please let me know.
Thanks,
Sanjay Tripathi
Re: Review Request: CS-15698: No option to update customer vpn gateway
details through UI
Posted by Pranav Saxena <pr...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/6230/#review9630
-----------------------------------------------------------
Looks good to me. I have verified it on my set up too. I'll ask Jessica to verify the patch on her set up too. Thanks for the patch !
- Pranav Saxena
On July 31, 2012, 9:10 a.m., Sanjay Tripathi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/6230/
> -----------------------------------------------------------
>
> (Updated July 31, 2012, 9:10 a.m.)
>
>
> Review request for cloudstack, Pranav Saxena, Brian Federle, and Jessica Wang.
>
>
> Description
> -------
>
> No option to update customer vpn gateway details through UI
>
> Steps to Reproduce:
> ==============
> 1.Bring UP CS in advanced zone
> 2.In UI go to Network->Select VPN Customer Gateway->add VPN Customer Gateway
> 3.Click on the vpn gateway added at step 2
> Details page has tabs to create vpn connection and to delete vpn customer gateway
> Does not have option to update vpn customer gateway.
>
>
> This addresses bug CS-15698.
>
>
> Diffs
> -----
>
> ui/scripts/network.js 0ae3850
>
> Diff: https://reviews.apache.org/r/6230/diff/
>
>
> Testing
> -------
>
> Verified on my local cloudstack setup.
>
> Currently only "IPsec Presharedkey" is kept as editable field, incase if there is any need to make other fields as editable, please let me know.
>
>
> Thanks,
>
> Sanjay Tripathi
>
>