You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "luoyuxia (Jira)" <ji...@apache.org> on 2021/06/03 04:06:00 UTC
[jira] [Commented] (FLINK-21686) Duplicate code in hive parser file
should be abstracted into functions
[ https://issues.apache.org/jira/browse/FLINK-21686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17356146#comment-17356146 ]
luoyuxia commented on FLINK-21686:
----------------------------------
[~humengyu] Thanks for your contribution. As the ci is failed for your pull request, would you like to rebase master to open the pull request and run the ci agin.
> Duplicate code in hive parser file should be abstracted into functions
> ----------------------------------------------------------------------
>
> Key: FLINK-21686
> URL: https://issues.apache.org/jira/browse/FLINK-21686
> Project: Flink
> Issue Type: Improvement
> Components: Connectors / Hive
> Reporter: humengyu
> Priority: Minor
> Labels: pull-request-available
>
> It would be better to use functions rather than duplicate code in hive parser file:
> # <IF> <EXISTS> option should be abstracted into a function;
> # <IF> <NOT> <EXISTS> option should be abstracted into a function.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)