You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/09/09 14:21:12 UTC
[GitHub] [geode-native] mmartell opened a new pull request #649: GEODE-8449: Cleanup containers before each test
mmartell opened a new pull request #649:
URL: https://github.com/apache/geode-native/pull/649
This cleans up any docker containers at the beginning of each test in case of a test failure that leaves docker containers up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r486525396
##########
File path: cppcache/acceptance-test/SNITest.cpp
##########
@@ -52,6 +52,8 @@ class SNITest : public ::testing::Test {
~SNITest() override = default;
void SetUp() override {
+ TearDown();
Review comment:
Agreed. Employing a utility function as above.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r486510049
##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -34,6 +34,8 @@ public class SNITests : TestBase, IDisposable
public SNITests(ITestOutputHelper testOutputHelper) : base(testOutputHelper)
{
+ Dispose();
Review comment:
Yeah, please create a utility method to call from Dispose, and call that here. Calling Dispose directly is legal, but technically misuse of the semantics of IDisposable.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r486510125
##########
File path: cppcache/acceptance-test/SNITest.cpp
##########
@@ -52,6 +52,8 @@ class SNITest : public ::testing::Test {
~SNITest() override = default;
void SetUp() override {
+ TearDown();
Review comment:
Yep
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell merged pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
mmartell merged pull request #649:
URL: https://github.com/apache/geode-native/pull/649
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] mmartell commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
mmartell commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r486524981
##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -34,6 +34,8 @@ public class SNITests : TestBase, IDisposable
public SNITests(ITestOutputHelper testOutputHelper) : base(testOutputHelper)
{
+ Dispose();
Review comment:
Agreed. Though legal, it looks a bit weird to call Dispose directly.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] moleske commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
moleske commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r488065099
##########
File path: cppcache/acceptance-test/SNITest.cpp
##########
@@ -52,6 +52,8 @@ class SNITest : public ::testing::Test {
~SNITest() override = default;
void SetUp() override {
+ TearDown();
Review comment:
This looks like it was merged with `TearDown()` being called instead of `cleanupDocker()` function...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] echobravopapa commented on a change in pull request #649: GEODE-8449: Cleanup containers before each test
Posted by GitBox <gi...@apache.org>.
echobravopapa commented on a change in pull request #649:
URL: https://github.com/apache/geode-native/pull/649#discussion_r485715946
##########
File path: clicache/acceptance-test/SNITests.cs
##########
@@ -34,6 +34,8 @@ public class SNITests : TestBase, IDisposable
public SNITests(ITestOutputHelper testOutputHelper) : base(testOutputHelper)
{
+ Dispose();
Review comment:
does this make sense for C# language? using the `Dispose` method...?
##########
File path: cppcache/acceptance-test/SNITest.cpp
##########
@@ -52,6 +52,8 @@ class SNITest : public ::testing::Test {
~SNITest() override = default;
void SetUp() override {
+ TearDown();
Review comment:
same thing here... `gtest` uses `TearDown` as a special method... I wonder if it would be better to have a utility method for both that is called from the constructor in C# and `SetUp` in this test...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org