You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by rashmidixit <gi...@git.apache.org> on 2016/12/22 06:11:39 UTC
[GitHub] cloudstack pull request #1852: VM snapshot is disabled if the VM Instance is...
GitHub user rashmidixit opened a pull request:
https://github.com/apache/cloudstack/pull/1852
VM snapshot is disabled if the VM Instance is off
Refer to [CLOUDSTACK-9695](https://issues.apache.org/jira/browse/CLOUDSTACK-9695) for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9695
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1852
----
commit c5bd65589f3be915d9fe42c71447a7a9bdf1c2d9
Author: Sanket Thite <sa...@accelerite.com>
Date: 2016-07-12T09:50:47Z
VM snapshot is disabled if the VM Instance is off
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: VM snapshot is disabled if the VM Instance is off
Posted by rashmidixit <gi...@git.apache.org>.
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1852
@rhtyd This is a minor improvement and hence in master. I have updated the corresponding bugs' fix version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...
Posted by rashmidixit <gi...@git.apache.org>.
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1852
@ustcweizhou The reason for not putting this in vmActionFilter is that the snapshot action itself is allowed when a VM is shut down. We only want to disable the option for memory snapshot which is not valid in this case. Hope this clarifies.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: VM snapshot is disabled if the VM Instance is off
Posted by rashmidixit <gi...@git.apache.org>.
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1852
As part of this fix, added a new property called "isDisabled" for a field in a dialog. If this function returns true, then the field will be disabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: VM snapshot is disabled if the VM Instance is off
Posted by rhtyd <gi...@git.apache.org>.
Github user rhtyd commented on the issue:
https://github.com/apache/cloudstack/pull/1852
@rashmidixit change the PR's base branch to 4.9 please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...
Posted by rashmidixit <gi...@git.apache.org>.
Github user rashmidixit commented on the issue:
https://github.com/apache/cloudstack/pull/1852
ping @koushik-das.
When VM is running and snapshot option is clicked, the memory option is enabled.
When VM is stopped and snapshot option is clicked, the memory option is disabled.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1852: CLOUDSTACK-9695: VM snapshot is disabled if t...
Posted by rashmidixit <gi...@git.apache.org>.
Github user rashmidixit closed the pull request at:
https://github.com/apache/cloudstack/pull/1852
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request #1852: CLOUDSTACK-9695: VM snapshot is disabled if t...
Posted by rashmidixit <gi...@git.apache.org>.
GitHub user rashmidixit reopened a pull request:
https://github.com/apache/cloudstack/pull/1852
CLOUDSTACK-9695: VM snapshot is disabled if the VM Instance is off
Refer to [CLOUDSTACK-9695](https://issues.apache.org/jira/browse/CLOUDSTACK-9695) for more details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Accelerite/cloudstack CLOUDSTACK-9695
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1852.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1852
----
commit 00a47802ce279900fef444ec7069b57418dda204
Author: Sanket Thite <sa...@accelerite.com>
Date: 2016-07-12T09:50:47Z
VM snapshot is disabled if the VM Instance is off
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...
Posted by ustcweizhou <gi...@git.apache.org>.
Github user ustcweizhou commented on the issue:
https://github.com/apache/cloudstack/pull/1852
why not change vmActionfilter in ui/scripts/instances.js ?
it will be much simple.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack issue #1852: CLOUDSTACK-9695: VM snapshot is disabled if the VM I...
Posted by koushik-das <gi...@git.apache.org>.
Github user koushik-das commented on the issue:
https://github.com/apache/cloudstack/pull/1852
@rashmidixit Code LGTM. Please provide screenshots of the changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---