You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kylin.apache.org by GitBox <gi...@apache.org> on 2021/02/23 07:12:12 UTC

[GitHub] [kylin] zzcclp commented on a change in pull request #1586: KYLIN-4905 Support limit .. offset ... in spark query engine

zzcclp commented on a change in pull request #1586:
URL: https://github.com/apache/kylin/pull/1586#discussion_r580809195



##########
File path: query/src/main/java/org/apache/kylin/query/relnode/OLAPTableScan.java
##########
@@ -211,6 +212,8 @@ public void register(RelOptPlanner planner) {
 
         // see Dec 26th email @ http://mail-archives.apache.org/mod_mbox/calcite-dev/201412.mbox/browser
         planner.removeRule(ExpandConversionRule.INSTANCE);
+        //TODO KYLIN-4905 currently spark doesn't support limit...offset.., keep sort always the root RelNode
+        planner.removeRule(SortProjectTransposeRule.INSTANCE);

Review comment:
       add a detailed comment to describe why need to remove 'SortProjectTransposeRule' rule.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org