You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Saqeeb Shaikh <sa...@gmail.com> on 2016/06/07 12:35:38 UTC
Review Request 48339: ATLAS-853 User's name to be mentioned in the
top user drop down
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48339/
-----------------------------------------------------------
Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
Bugs: ATLAS-853
https://issues.apache.org/jira/browse/ATLAS-853
Repository: atlas
Description
-------
Added new API /api/atlas/admin/session to obtain logged in user information. This is a part of Admin API.
Diffs
-----
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 48b536f
dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html 006fe0b
dashboardv2/public/js/templates/site/header.html 8c22e5a
dashboardv2/public/js/utils/CommonViewFunction.js 3baeb34
dashboardv2/public/js/utils/Globals.js 078881e
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js aad4bab
dashboardv2/public/js/views/site/Header.js cf97a75
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 36b7607
Diff: https://reviews.apache.org/r/48339/diff/
Testing
-------
mvn install and package
The API call to test the result JSON :: /api/atlas/admin/session
Testing result :: {"userName":"admin","groups":["ADMIN"]}
Thanks,
Saqeeb Shaikh
Re: Review Request 48339: ATLAS-853 User's name to be mentioned in
the top user drop down
Posted by Madhan Neethiraj <ma...@apache.org>.
Saqeeb,
Login using Kerberos shows the following text in the username field. Can you please review and update?
Thanks,
Madhan
From: Saqeeb Shaikh <no...@reviews.apache.org> on behalf of Saqeeb Shaikh <sa...@gmail.com>
Reply-To: Saqeeb Shaikh <sa...@gmail.com>
Date: Tuesday, June 7, 2016 at 5:35 AM
To: Hemanth Yamijala <yh...@gmail.com>, Madhan Neethiraj <ma...@apache.org>, Mehul Parikh <xs...@gmail.com>, Gautam Borad <gb...@gmail.com>, Shwetha Shivalingamurthy <ss...@hortonworks.com>
Cc: atlas <de...@atlas.incubator.apache.org>, Saqeeb Shaikh <sa...@gmail.com>
Subject: Review Request 48339: ATLAS-853 User's name to be mentioned in the top user drop down
This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/48339/
Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
By Saqeeb Shaikh.
Bugs: ATLAS-853
Repository: atlas
Description
Added new API /api/atlas/admin/session to obtain logged in user information. This is a part of Admin API.
Testing
mvn install and package
The API call to test the result JSON :: /api/atlas/admin/session
Testing result :: {"userName":"admin","groups":["ADMIN"]}
Diffs
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java (48b536f)
dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html (006fe0b)
dashboardv2/public/js/templates/site/header.html (8c22e5a)
dashboardv2/public/js/utils/CommonViewFunction.js (3baeb34)
dashboardv2/public/js/utils/Globals.js (078881e)
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js (aad4bab)
dashboardv2/public/js/views/site/Header.js (cf97a75)
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java (36b7607)
View Diff
Re: Review Request 48339: ATLAS-853 User's name to be mentioned in
the top user drop down
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48339/#review136769
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On June 8, 2016, 11:55 a.m., Saqeeb Shaikh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/48339/
> -----------------------------------------------------------
>
> (Updated June 8, 2016, 11:55 a.m.)
>
>
> Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
>
>
> Bugs: ATLAS-853
> https://issues.apache.org/jira/browse/ATLAS-853
>
>
> Repository: atlas
>
>
> Description
> -------
>
> Added new API /api/atlas/admin/session to obtain logged in user information. This is a part of Admin API.
>
>
> Diffs
> -----
>
> authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 48b536f
> dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html 006fe0b
> dashboardv2/public/js/templates/site/header.html 8c22e5a
> dashboardv2/public/js/utils/CommonViewFunction.js d2de0dc
> dashboardv2/public/js/utils/Globals.js 078881e
> dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js aad4bab
> dashboardv2/public/js/views/site/Header.js cf97a75
> webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java d87120c
> webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 36b7607
>
> Diff: https://reviews.apache.org/r/48339/diff/
>
>
> Testing
> -------
>
> mvn install and package
>
> The API call to test the result JSON :: /api/atlas/admin/session
>
> Testing result :: {"userName":"admin","groups":["ADMIN"]}
>
>
> Thanks,
>
> Saqeeb Shaikh
>
>
Re: Review Request 48339: ATLAS-853 User's name to be mentioned in
the top user drop down
Posted by Saqeeb Shaikh <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/48339/
-----------------------------------------------------------
(Updated June 8, 2016, 11:55 a.m.)
Review request for atlas, Gautam Borad, Madhan Neethiraj, Mehul Parikh, Shwetha GS, and Hemanth Yamijala.
Changes
-------
Fix for improper user name in kerberized setup. Changed the method to getName() from getPrincipal(), to obtain the user name from the Security Context.
Bugs: ATLAS-853
https://issues.apache.org/jira/browse/ATLAS-853
Repository: atlas
Description
-------
Added new API /api/atlas/admin/session to obtain logged in user information. This is a part of Admin API.
Diffs (updated)
-----
authorization/src/main/java/org/apache/atlas/authorize/simple/AtlasAuthorizationUtils.java 48b536f
dashboardv2/public/js/templates/business_catalog/BusinessCatalogHeader.html 006fe0b
dashboardv2/public/js/templates/site/header.html 8c22e5a
dashboardv2/public/js/utils/CommonViewFunction.js d2de0dc
dashboardv2/public/js/utils/Globals.js 078881e
dashboardv2/public/js/views/business_catalog/BusinessCatalogHeader.js aad4bab
dashboardv2/public/js/views/site/Header.js cf97a75
webapp/src/main/java/org/apache/atlas/web/filters/AtlasAuthorizationFilter.java d87120c
webapp/src/main/java/org/apache/atlas/web/resources/AdminResource.java 36b7607
Diff: https://reviews.apache.org/r/48339/diff/
Testing
-------
mvn install and package
The API call to test the result JSON :: /api/atlas/admin/session
Testing result :: {"userName":"admin","groups":["ADMIN"]}
Thanks,
Saqeeb Shaikh