You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@impala.apache.org by "Henry Robinson (Code Review)" <ge...@cloudera.org> on 2016/12/15 19:58:54 UTC
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Henry Robinson has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5522
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
IMPALA-4652: Add crcutil to toolchain
Note: crcutil does not have any release tarballs, so we borrow the one
built for Apache Kudu. As a result, the build version is a git hash,
rather than e.g. 1.0.
The package builds on all supported platforms, except for CentOS 5.X due
to the outdated autotools on that platform. As a workaround, the script
will download and locally install autoconf / automake / libtool if it
detects it is on CentOS 5.X. Doing so only adds a few seconds to the build.
Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
---
M buildall.sh
A source/crcutil/build.sh
2 files changed, 73 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/22/5522/1
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#3).
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
IMPALA-4652: Add crcutil to toolchain
Note: crcutil does not have any release tarballs, so we borrow the one
built for Apache Kudu. As a result, the build version is a git hash,
rather than e.g. 1.0.
Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
---
M buildall.sh
A source/crcutil/build.sh
2 files changed, 46 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/22/5522/3
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
Patch Set 1:
Oh, that's a good idea - didn't realise there was a separate way to get build dependencies installed. I'll do that.
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has submitted this change and it was merged.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
IMPALA-4652: Add crcutil to toolchain
Note: crcutil does not have any release tarballs, so we borrow the one
built for Apache Kudu. As a result, the build version is a git hash,
rather than e.g. 1.0.
Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
---
M buildall.sh
A source/crcutil/build.sh
2 files changed, 46 insertions(+), 0 deletions(-)
Approvals:
Henry Robinson: Verified
Tim Armstrong: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has uploaded a new patch set (#2).
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
IMPALA-4652: Add crcutil to toolchain
Note: crcutil does not have any release tarballs, so we borrow the one
built for Apache Kudu. As a result, the build version is a git hash,
rather than e.g. 1.0.
The package builds on all supported platforms, except for CentOS 5.X due
to the outdated autotools on that platform. As a workaround, the script
will download and locally install autoconf / automake / libtool if it
detects it is on CentOS 5.X. Doing so only adds a few seconds to the build.
Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
---
M buildall.sh
A source/crcutil/build.sh
2 files changed, 44 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Toolchain refs/changes/22/5522/2
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
Patch Set 1:
IMO we should just add autotools as a toolchain package. We could install it and add it to the path as part of init.sh like cmake and binutils.
We don't really have a firm guarantee that other distros come with specific versions of autotools so that would be another step towards the toolchain builds being more reproducible
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
Patch Set 3: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5522/2//COMMIT_MSG
Commit Message:
PS2, Line 13: The package builds on all supported platforms, except for CentOS 5.X due
: to the outdated autotools on that platform. As a workaround, the script
: will download and locally install autoconf / automake / libtool if it
: detects it is on CentOS 5.X. Doing so only adds a few seconds to the build.
Will remove this.
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 2
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: Yes
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Tim Armstrong (Code Review)" <ge...@cloudera.org>.
Tim Armstrong has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
Patch Set 3: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 3
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Tim Armstrong <ta...@cloudera.com>
Gerrit-HasComments: No
[Toolchain-CR] IMPALA-4652: Add crcutil to toolchain
Posted by "Henry Robinson (Code Review)" <ge...@cloudera.org>.
Henry Robinson has posted comments on this change.
Change subject: IMPALA-4652: Add crcutil to toolchain
......................................................................
Patch Set 1:
I'm running a full build for this right now - it passes locally - but I'd like any early feedback on the approach. It's maybe a bit hacky to install auto* for this dependency only, but I think the implementation came out fairly clean.
--
To view, visit http://gerrit.cloudera.org:8080/5522
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ibf8b39082914b1b2932b4ce7efbd2cc4f5f69743
Gerrit-PatchSet: 1
Gerrit-Project: Toolchain
Gerrit-Branch: master
Gerrit-Owner: Henry Robinson <he...@cloudera.com>
Gerrit-Reviewer: Henry Robinson <he...@cloudera.com>
Gerrit-HasComments: No