You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by GitBox <gi...@apache.org> on 2022/09/23 11:39:26 UTC
[GitHub] [incubator-eventmesh] eshikarya opened a new pull request, #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
eshikarya opened a new pull request, #1388:
URL: https://github.com/apache/incubator-eventmesh/pull/1388
<!--
### Contribution Checklist
- Name the pull request in the form "[ISSUE #XXXX] Title of the pull request",
where *XXXX* should be replaced by the actual issue number.
Skip *[ISSUE #XXXX]* if there is no associated github issue for this pull request.
- Fill out the template below to describe the changes contributed by the pull request.
That will give reviewers the context they need to do the review.
- Each pull request should address only one issue.
Please do not mix up code from multiple issues.
- Each commit in the pull request should have a meaningful commit message.
- Once all items of the checklist are addressed, remove the above text and this checklist,
leaving only the filled out template below.
(The sections below can be removed for hotfixes of typos)
-->
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Cloese #<XXX>`.)
-->
Fixes #1372
### Motivation
*Document directory rectification*
### Modifications
*Moved documents from metrics-tracing directory to design-document directory*
*metrics-tracing directory deleted*
### Documentation
- Does this pull request introduce a new feature? (yes / no) - NO
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented) - NA
- If a feature is not applicable for documentation, explain why?- NA
- If a feature is not documented yet in this PR, please create a followup issue for adding the documentation- NA
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] eshikarya closed pull request #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
Posted by GitBox <gi...@apache.org>.
eshikarya closed pull request #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
URL: https://github.com/apache/incubator-eventmesh/pull/1388
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] eshikarya commented on pull request #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
Posted by GitBox <gi...@apache.org>.
eshikarya commented on PR #1388:
URL: https://github.com/apache/incubator-eventmesh/pull/1388#issuecomment-1256417408
@qqeasonchen I haven't made changes to any file contents
I have done this based on the description provided in https://github.com/apache/incubator-eventmesh/issues/1372
1. Move the documents from metrics-training directory to design-document directory.
2. delete the metrics-tracing directory.
3. "Then the next file should start with 11-." -> The 2 files moved from metrics-training were reformatted to "11-<name>", "12-<name"
pls let me know if something other than this is to be done?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1388:
URL: https://github.com/apache/incubator-eventmesh/pull/1388#issuecomment-1256856496
@eshikarya Yes, what you descripe is correct, but 67 files changed in your pr, including java files.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] eshikarya commented on pull request #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
Posted by GitBox <gi...@apache.org>.
eshikarya commented on PR #1388:
URL: https://github.com/apache/incubator-eventmesh/pull/1388#issuecomment-1257041514
@qqeasonchen I haven't done anything regarding this. Let me try doing it again.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [incubator-eventmesh] qqeasonchen commented on pull request #1388: [Issue #1372] Document directory rectification [en metrics-tracing]
Posted by GitBox <gi...@apache.org>.
qqeasonchen commented on PR #1388:
URL: https://github.com/apache/incubator-eventmesh/pull/1388#issuecomment-1256330735
@eshikarya It's no need to chang other files except changing the path of docs for metrics and tracing, maybe there is a misunderstanding.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org