[jira] [Comment Edited] (TEZ-700) Helper API's to monitor a DAG to completion

["Bikas Saha (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/TEZ-700?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13968707#comment-13968707 ] 

Bikas Saha edited comment on TEZ-700 at 4/14/14 7:23 PM:
---------------------------------------------------------

I mean 
{code} VertexStatus vStatus = getVertexStatus(vertex, (displayVertexCounters ? opts : null));{code} becomes {code} VertexStatus vStatus = getVertexStatus(vertex, opts));{code}
And inside printDAGStatus() instead of a method argument, we do {code} displayCounters = opts!=null ? opts.contains(StatusGetOpts.COUNTERS) : false{code}

Also Set<StatusGetOpts> opts should be nullable.

Lets make WordCount use waitForCompletionWithAllStatusUpdates(null). And change UnionExample use DAGStatus waitForCompletionWithAllStatusUpdates(vertices, COUNTERS). UnionExample is the other cleanly written example that runs in every maven unit test. If possible you could modify that example to use the new API's too.






was (Author: bikassaha):
I mean 
{code} VertexStatus vStatus = getVertexStatus(vertex, (displayVertexCounters ? opts : null));{code} becomes {code} VertexStatus vStatus = getVertexStatus(vertex, opts));{code}
And inside printDAGStatus() instead of a method argument, we do {code} displayVertexCounters = opts!=null ? opts.contains(StatusGetOpts.COUNTERS) : false{code}

Also Set<StatusGetOpts> opts should be nullable.

Lets make WordCount use waitForCompletionWithAllStatusUpdates(null). And change UnionExample use DAGStatus waitForCompletionWithAllStatusUpdates(vertices, COUNTERS). UnionExample is the other cleanly written example that runs in every maven unit test. If possible you could modify that example to use the new API's too.





> Helper API's to monitor a DAG to completion
> -------------------------------------------
>
>                 Key: TEZ-700
>                 URL: https://issues.apache.org/jira/browse/TEZ-700
>             Project: Apache Tez
>          Issue Type: Sub-task
>            Reporter: Bikas Saha
>            Assignee: Mohammad Kamrul Islam
>         Attachments: TEZ-700.1.patch, TEZ-700.2.patch, TEZ-700.3.patch, TEZ-700.4.patch, TEZ-700.5.patch, TEZ-700.6.patch
>
>
> There is a lot of boiler plate code to monitor a dag progress to completion. A simple API to monitor the job to completion will be reduce this burden.



--
This message was sent by Atlassian JIRA
(v6.2#6252)