You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by "sdedic (via GitHub)" <gi...@apache.org> on 2023/01/23 17:52:43 UTC
[GitHub] [netbeans] sdedic opened a new pull request, #5352: Springboot artifacts fix
sdedic opened a new pull request, #5352:
URL: https://github.com/apache/netbeans/pull/5352
There's a springboot module on the Plugin portal, but that one does not handle native-image compilation. Longer term, I'd like to create a dedicated native-image supporting module(s) and move the gradle+maven plugin support there. But for NBLS immediate release and NB17 release, I'd like to include a very trivial springboot support - Micronaut module is a good enterprise cluster candidate to make homeplace for it.
The PR adds ability to run native compilation from the NetBeans IDE based on springboot plugin support. In addition, springboot projects are configured differently to micronaut projects - the changes in `MicronautPackagingArtifactsImpl` make the impl more compatible with various setups, as it now reacts on the plugin's goal regardless of whether the plugin is bound to the buildchain.
The maven module part is a necessary subtle API change - the friend API did allow to create `RunConfig`s for an explicit goal, but not for an (abstract) project action which is needed here, and uses possible user's customizations for the action (and therefore the goal). It fits well to the `RunUtils` API function set.
I'd like to include this PR into NB17 release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5352: Springboot artifacts fix
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#issuecomment-1405021996
Thanks! That looks OK to me from perspective of merging to delivery.
I'll leave @MartinBalin to review in full and handle merging.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin merged pull request #5352: Springboot artifacts fix
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin merged PR #5352:
URL: https://github.com/apache/netbeans/pull/5352
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #5352: Springboot artifacts fix
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087643842
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
As far as I can see, this should actually be?
`spec.version.base=2.157.0`
Use of colon means it gets skipped in increment task, and if not skipped needs to end with `.0`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on a diff in pull request #5352: Springboot artifacts fix
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087734258
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
@neilcsmith-net - I am confused; so should I rebase against `delivery` plus adjust spec numbers to fit into `delivery` codebase ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on pull request #5352: Springboot artifacts fix
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#issuecomment-1404792850
@MartinBalin nothing stopping the changes going into delivery and NB17 if you want them there, as long as the PR is updated to allow merging to delivery.
@sdedic assertion above about spec versions is wrong. The Maven module is incorrectly configured here as far as I can see (comment inline with code). It is certainly skipped when spec versions get incremented. So we won't get a merge conflict with master, but should fix it I think? And once delivery is synced, increment again?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #5352: Springboot artifacts fix
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087754209
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
@sdedic yes, it's confusing! To get into NB17 it needs to be based on top of `delivery`. Normally, spec versions can't change in `delivery`, because the first thing we do on `master` at branch is a spec version increment (eg. #5312 )
However, the `maven` (and `java.editor.lib`) modules use a colon rather than equals in the properties file, and are being missed out of that increment. I've only just noticed that.
IMO, unless there's a reason those modules shouldn't be incrementing every release, we should change this to what I suggested in my previous comment, and keep your API comments as is, when rebasing on top of delivery.
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
@sdedic yes, it's confusing! To get into NB17 it needs to be based on top of `delivery`. Normally, spec versions can't change in `delivery`, because the first thing we do on `master` after branch is a spec version increment (eg. #5312 )
However, the `maven` (and `java.editor.lib`) modules use a colon rather than equals in the properties file, and are being missed out of that increment. I've only just noticed that.
IMO, unless there's a reason those modules shouldn't be incrementing every release, we should change this to what I suggested in my previous comment, and keep your API comments as is, when rebasing on top of delivery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #5352: Springboot artifacts fix
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087754209
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
@sdedic yes, it's confusing! To get into NB17 it needs to be based on top of `delivery`. Normally, spec versions are fixed from branch, because the first thing we do on `master` at branch is a spec version increment (eg. #5312 )
However, the `maven` (and `java.editor.lib`) modules use a colon rather than equals in the properties file, and are being missed out of that increment. I've only just noticed that.
IMO, unless there's a reason those modules shouldn't be incrementing every release, we should change this to what I suggested in my previous comment, and keep your API comments as is, when rebasing on top of delivery.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] sdedic commented on pull request #5352: Springboot artifacts fix
Posted by "sdedic (via GitHub)" <gi...@apache.org>.
sdedic commented on PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#issuecomment-1404966392
Rebased onto `delivery`. Maven's spec version changed to use `=` and to `2.157.0`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] neilcsmith-net commented on a diff in pull request #5352: Springboot artifacts fix
Posted by "neilcsmith-net (via GitHub)" <gi...@apache.org>.
neilcsmith-net commented on code in PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#discussion_r1087643842
##########
java/maven/nbproject/project.properties:
##########
@@ -22,7 +22,7 @@ javadoc.apichanges=${basedir}/apichanges.xml
javadoc.arch=${basedir}/arch.xml
javahelp.hs=maven.hs
extra.module.files=maven-nblib/
-spec.version.base: 2.156
+spec.version.base: 2.157
Review Comment:
As far as I can see, this should actually be?
`spec.version.base=2.157.0`
Use of colon means it gets skipped in increment task, and if not skipped needs to end with `.0`? See https://github.com/apache/netbeans/blob/master/nbbuild/antsrc/org/netbeans/nbbuild/IncrementSpecificationVersions.java#L96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists
[GitHub] [netbeans] MartinBalin commented on pull request #5352: Springboot artifacts fix
Posted by "MartinBalin (via GitHub)" <gi...@apache.org>.
MartinBalin commented on PR #5352:
URL: https://github.com/apache/netbeans/pull/5352#issuecomment-1404657545
I agree with what Neils says. But, without this fix which is needed for some of the GraalVM+SpringBoot support in VSNetBeans we will need to either diverge VSNetBeans code from NetBeans code or do a hacky solution elsewhere... I propose to do this and then fix it properly in master after NB17?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org
For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists