[GitHub] [kvrocks] git-hulk commented on a diff in pull request #1740: Add the client name and ipport to the slowlog output

["git-hulk (via GitHub)" <gi...@apache.org>]

git-hulk commented on code in PR #1740:
URL: https://github.com/apache/kvrocks/pull/1740#discussion_r1315764619


##########
src/server/server.cc:
##########
@@ -1407,7 +1407,8 @@ time_t Server::GetLastScanTime(const std::string &ns) {
   return 0;
 }
 
-void Server::SlowlogPushEntryIfNeeded(const std::vector<std::string> *args, uint64_t duration) {
+void Server::SlowlogPushEntryIfNeeded(const std::vector<std::string> *args, uint64_t duration, std::string client_name,

Review Comment:
   Is it better to pass the `const Connection *conn` here? instead of passing its member one by one.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org