You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/03/17 13:39:50 UTC

[GitHub] [pulsar] asardaes opened a new issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

asardaes opened a new issue #14733:
URL: https://github.com/apache/pulsar/issues/14733


   I'm using an admin client configured with a cert/key pair file and a trusted certificate file, the latter of which is a bundle with multiple certificates. From what I can tell, the client is created with an instance of [`TrustManagerProxy`](https://github.com/apache/pulsar/blob/master/pulsar-common/src/main/java/org/apache/pulsar/common/util/TrustManagerProxy.java#L77), which uses `CertificateFactory#generateCertificate` (singular) instead of `CertificateFactory#generateCertificates` (plural) and thus doesn't load all certificates in the bundle.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] asardaes edited a comment on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
asardaes edited a comment on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1072191081


   I don't have one, the client is created using `org.apache.pulsar.client.admin.PulsarAdminBuilder` and setting `tlsTrustCertsFilePath`. Note that the client is used by the Flink-Pulsar connector, and it seems that it also uses `org.apache.pulsar.client.impl.AuthenticationUtil#create` under the hood to instantiate `org.apache.pulsar.client.impl.auth.AuthenticationTls`. In the end, I think the important bit is that `AsyncHttpConnector` is used, and that calls `SecurityUtility#createNettySslContextForClient`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] asardaes commented on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
asardaes commented on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1072191081


   I don't have one, the client is created using `org.apache.pulsar.client.admin.PulsarAdminBuilder` and setting `tlsTrustCertsFilePath`. Note that the client is used by the Flink-Pulsar connector, and it seems that it also uses `org.apache.pulsar.client.impl.AuthenticationUtil#create` under the hood to instantiate `org.apache.pulsar.client.impl.auth.AuthenticationTls`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nodece commented on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
nodece commented on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1074945606


   I submitted https://github.com/apache/pulsar/pull/14798 to support this, could you review this PR?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nodece commented on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
nodece commented on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1072070059


   Could you provide your config file?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] asardaes edited a comment on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
asardaes edited a comment on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1072191081


   I don't have one, the client is created using `org.apache.pulsar.client.admin.PulsarAdminBuilder` and setting `tlsTrustCertsFilePath`. Note that the client is used by the Flink-Pulsar connector, and it seems that it also uses `org.apache.pulsar.client.impl.AuthenticationUtil#create` under the hood to instantiate `org.apache.pulsar.client.impl.auth.AuthenticationTls`. In the end, I think the important bit is that `AsyncHttpConnector` is used, and that calls `SecurityUtility#createNettySslContextForClient`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] asardaes commented on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
asardaes commented on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1072191081


   I don't have one, the client is created using `org.apache.pulsar.client.admin.PulsarAdminBuilder` and setting `tlsTrustCertsFilePath`. Note that the client is used by the Flink-Pulsar connector, and it seems that it also uses `org.apache.pulsar.client.impl.AuthenticationUtil#create` under the hood to instantiate `org.apache.pulsar.client.impl.auth.AuthenticationTls`.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [pulsar] nodece commented on issue #14733: TrustManagerProxy will not load a file with multiple certificates correctly

Posted by GitBox <gi...@apache.org>.
nodece commented on issue #14733:
URL: https://github.com/apache/pulsar/issues/14733#issuecomment-1072070059


   Could you provide your config file?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org