[GitHub] [flink] dianfu commented on a change in pull request #11107: [FLINK-16071][python] Optimize the cost of the get item of the Row

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #11107: [FLINK-16071][python] Optimize the cost of the get item of the Row
URL: https://github.com/apache/flink/pull/11107#discussion_r380041385
 
 

 ##########
 File path: flink-python/pyflink/fn_execution/coders.py
 ##########
 @@ -31,31 +32,31 @@
 FLINK_SCHEMA_CODER_URN = "flink:coder:schema:v1"
 
 
-__all__ = ['RowCoder', 'BigIntCoder', 'TinyIntCoder', 'BooleanCoder',
+__all__ = ['FlattenRowCoder', 'RowCoder', 'BigIntCoder', 'TinyIntCoder', 'BooleanCoder',
            'SmallIntCoder', 'IntCoder', 'FloatCoder', 'DoubleCoder',
            'BinaryCoder', 'CharCoder', 'DateCoder', 'TimeCoder',
            'TimestampCoder', 'ArrayCoder', 'MapCoder', 'DecimalCoder']
 
 
-class RowCoder(FastCoder):
+class FlattenRowCoder(FastCoder):
     """
-    Coder for Row.
+    Coder for Row. The result of decode will be list for the performance.
 
 Review comment:
   The result of decode will be list for the performance. -> The decoded result will be flattened as a list of column values of a row instead of a row object.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services