You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by bu...@apache.org on 2020/04/01 06:30:54 UTC
[Bug 64297] New: mod_md uninitialized variable
https://bz.apache.org/bugzilla/show_bug.cgi?id=64297
Bug ID: 64297
Summary: mod_md uninitialized variable
Product: Apache httpd-2
Version: 2.5-HEAD
Hardware: All
OS: All
Status: NEW
Severity: critical
Priority: P2
Component: mod_md
Assignee: bugs@httpd.apache.org
Reporter: toan.sec@gmail.com
Target Milestone: ---
Hi,
When auditing httpd I caught this bug,
https://github.com/apache/httpd/blob/trunk/modules/md/md_acme.c#L170
static apr_status_t inspect_problem(md_acme_req_t *req, const
md_http_response_t *res)
{
const char *ctype;
md_json_t *problem; (1)
ctype = apr_table_get(req->resp_hdrs, "content-type");
if (ctype && !strcmp(ctype, "application/problem+json")) {
/* RFC 7807 */
md_json_read_http(&problem, req->p, res); (2)
if (problem) { (3)
const char *ptype, *pdetail;
----
https://github.com/apache/httpd/blob/trunk/modules/md/md_json.c#L1160
apr_status_t md_json_read_http(md_json_t **pjson, apr_pool_t *pool, const
md_http_response_t *res)
{
apr_status_t rv = APR_ENOENT;
const char *ctype = apr_table_get(res->headers, "content-type");
if (ctype && res->body (4) && (strstr(ctype, "/json") || strstr(ctype,
"+json"))) {
rv = md_json_readb(pjson, pool, res->body);
}
return rv;
Variable problem uninitialized at (1) and pass as a pointer to
md_json_read_http at (2), if res->body is null at (4) it will return APR_ENOENT
without init pjson( or problem ).
At (3) use [problem] without any check on return value of md_json_read_http so
[problem] never get init.
It look like if attacker can control authority server he can exploit this bug.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 64297] mod_md uninitialized variable
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64297
--- Comment #1 from Stefan Eissing <st...@eissing.org> ---
Thanks for your report.
I agree that md_json_read_http() should NULL the pointer if the response is not
of a json content type. I will fix the code accordingly.
As for an attack, the function is only called when a "json" content type has
been detected. I fail to see how an uninitialized *problem could be accessed.
Maybe I am not seeing something?
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 64297] mod_md uninitialized variable
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64297
Rich Bowen <rb...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|NEW |RESOLVED
--- Comment #3 from Rich Bowen <rb...@apache.org> ---
Thank you for your report. As part of an effort to clean up our issue tracker,
we are closing tickets that have seen no activity for more than 5 years. If
this issue is still relevant to a current version of Apache httpd (2.4.x or
trunk), please reopen this ticket or open a new one with updated information.
We appreciate your contribution to the project.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
[Bug 64297] mod_md uninitialized variable
Posted by bu...@apache.org.
https://bz.apache.org/bugzilla/show_bug.cgi?id=64297
--- Comment #2 from toan.sec@gmail.com ---
Hi Stefan,
Yeah indeed I think you right, so I dive in md_json_readb and see this
apr_status_t md_json_readd(md_json_t **pjson, apr_pool_t *pool, const char
*data, size_t data_len)
{
json_error_t error;
json_t *j;
j = json_loadb(data, data_len, 0, &error); (5)
if (!j) {
return APR_EINVAL;
}
*pjson = json_create(pool, j);
return APR_SUCCESS;
}
so If we go to the branh:
rv = md_json_readb(pjson, pool, res->body);
it will trigger (5) with data is res->body under attacker control and I guess
can make it return 0 and it will keep pjson ( our *problem ) uninit as well.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org