You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2023/01/06 11:40:43 UTC

[GitHub] [incubator-seatunnel] lightzhao opened a new pull request, #3886: [Improve][HiveSink]Fix Partition loading failed.

lightzhao opened a new pull request, #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886

   1.If user sets 'partition_dir_expression = "${v0}"' in hive-sink,it means that the partition directory does not have a partition name. Then the partition loading will fail.
   2.Like this : /home/test/warehouse/test.db/tmp_test_day/20230106
   3.A new loading method is added for this case to ensure successful loading of partitions.
   
   <!--
   
   Thank you for contributing to SeaTunnel! Please make sure that your code changes
   are covered with tests. And in case of new features or big changes
   remember to adjust the documentation.
   
   Feel free to ping committers for the review!
   
   ## Contribution Checklist
   
     - Make sure that the pull request corresponds to a [GITHUB issue](https://github.com/apache/incubator-seatunnel/issues).
   
     - Name the pull request in the form "[Feature] [component] Title of the pull request", where *Feature* can be replaced by `Hotfix`, `Bug`, etc.
   
     - Minor fixes should be named following this pattern: `[hotfix] [docs] Fix typo in README.md doc`.
   
   -->
   
   ## Purpose of this pull request
   
   <!-- Describe the purpose of this pull request. For example: This pull request adds checkstyle plugin.-->
   
   ## Check list
   
   * [ ] Code changed are covered with tests, or it does not need tests for reason:
   * [ ] If any new Jar binary package adding in your PR, please add License Notice according
     [New License Guide](https://github.com/apache/incubator-seatunnel/blob/dev/docs/en/contribution/new-license.md)
   * [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
   * [ ] If you are contributing the connector code, please check that the following files are updated:
     1. Update change log that in connector document. For more details you can refer to [connector-v2](https://github.com/apache/incubator-seatunnel/tree/dev/docs/en/connector-v2)
     2. Update [plugin-mapping.properties](https://github.com/apache/incubator-seatunnel/blob/dev/plugin-mapping.properties) and add new connector information in it
     3. Update the pom file of [seatunnel-dist](https://github.com/apache/incubator-seatunnel/blob/dev/seatunnel-dist/pom.xml)
   * [ ] Update the [`release-note`](https://github.com/apache/incubator-seatunnel/blob/dev/release-note.md).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

Hisoka-X commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384785894

   > > If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way.
   > 
   > ok, If it is unreasonable, I will close it.
   
   No need, can your add the code in this PR to check `partition_name_expression` to make sure the partition always load success? If so will be very helpful.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

TyrantLucifer commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384844615

   cc @Hisoka-X 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

lightzhao commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1373727625

   @EricJoy2048 @Hisoka-X @TaoZex please review .thanks.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

lightzhao commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1383377977

   @EricJoy2048 @Hisoka-X @TaoZex Please see if this pr is reasonable. In fact, there are such use scenarios.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

lightzhao commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384781186

   > If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way.
   
   ok, If it is unreasonable, I will close it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] Hisoka-X commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

Hisoka-X commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1383601784

   If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] lightzhao commented on pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

lightzhao commented on PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886#issuecomment-1384815100

   > > > If does not have a partition name can't be loaded, why we should allow it? Maybe check `partition_name_expression` before execute job could be better way.
   > > 
   > > 
   > > ok, If it is unreasonable, I will close it.
   > 
   > No need, can your add the code in this PR to check `partition_name_expression` to make sure the partition always load success? If so will be very helpful.
   
   @Hisoka-X @TyrantLucifer PTAL, partition_dir_expression parameter adds the validation of the partition name to prevent the partition from failing to load


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-seatunnel] TyrantLucifer merged pull request #3886: [Improve][HiveSink]Fix Partition loading failed.

Posted by GitBox <gi...@apache.org>.

TyrantLucifer merged PR #3886:
URL: https://github.com/apache/incubator-seatunnel/pull/3886


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org